Add the function to customize the S3 domain#5411
Closed
Euruson wants to merge 2 commits intousememos:mainfrom
Closed
Add the function to customize the S3 domain#5411Euruson wants to merge 2 commits intousememos:mainfrom
Euruson wants to merge 2 commits intousememos:mainfrom
Conversation
Author
|
Also, I use Some S3-compatible providers return the bucket name as part of the filename for large files but not for small ones. This inconsistency stems from the multipart upload mechanism used for larger files, which can return a different key format than the single PUT mechanism used for smaller files. |
boojack
force-pushed
the
main
branch
2 times, most recently
from
a196c72 to
71e8a06
Compare
boojack
force-pushed
the
main
branch
2 times, most recently
from
2b6b987 to
47d9414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for configuring a custom domain (CDN) for S3 storage. When configured, attachment URLs will be generated using the custom domain instead of the default S3 presigned URLs. This allows for serving assets via a CDN or a custom domain name. Existing attachments will automatically migrate to the new URL format via the background runner immediately upon saving settings.
A lot of people asked for this feature to accelerate accessing and reduce network traffic costs:
#3575
#3717
#3819
#4852
#5191