Closed
Conversation
1b68883 to
c3a84d4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes command functionality in the memo editor by updating the cursor positioning system and adding new commands. It addresses issue #5330 and fixes a click interaction bug in the suggestions popup. The main changes include:
- Migrating from
cursorOffsettocursorRangeto support text selection after command insertion - Adding three new commands:
details,image, andyoutube - Fixing a focus-loss issue when clicking suggestion items by adding
preventDefault() - Updating existing commands to use the new cursor positioning system with text selection
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| web/src/components/MemoEditor/Editor/commands.ts | Replaces cursorOffset with cursorRange array format, adds details, image, and youtube commands, updates existing commands to select relevant placeholders |
| web/src/components/MemoEditor/Editor/CommandSuggestions.tsx | Implements cursor positioning logic to handle the new cursorRange format with text selection support |
| web/src/components/MemoEditor/Editor/SuggestionsPopup.tsx | Adds preventDefault() to mouse down handler to prevent focus loss when selecting suggestions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c08c7c5 to
a2c8873
Compare
a2c8873 to
b434f1c
Compare
a196c72 to
71e8a06
Compare
2b6b987 to
47d9414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5330
Additional changes:
detailsis not one of them, but IMO point 1.3 is the exact reason)Demo:
demo-shortkeys-1.mp4