feat(rss): Use server title and description for RSS feed, if configured #4717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilian-krauss
force-pushed
the
feat-rss-use-custom-settings
branch
from
b86a10d to
726da31
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the RSS feed functionality by using the server’s configured title and description for the feed metadata, ensuring consistency with the web UI.
- Introduces a new heading structure and a helper function to retrieve RSS heading information from workspace settings.
- Updates the feed generation to use the configured title and description when available.
Comments suppressed due to low confidence (1)
server/router/rss/rss.go:29
- [nitpick] The struct name 'heading' is ambiguous. Consider renaming it to 'RSSHeading' to more clearly reflect its purpose.
type heading struct {
f909b78 to
757d2e8
Compare
maximilian-krauss
force-pushed
the
feat-rss-use-custom-settings
branch
from
757d2e8 to
ad8e57b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As much as I like memos, I think it's confusing for users if the title and description is different than the one which shown on the web ui.
This PR adds those in the meta of the RSS feed too: