Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the Maven Central publishing configuration to eliminate hardcoded description strings. The change moves the project description from the PublishingPlugin to the project-level build file, making it more maintainable and adding validation to ensure the description is always set.
Changes:
- Added project description property to keeper-gradle-plugin build file
- Refactored PublishingPlugin to use project.description instead of hardcoded strings
- Added validation check to ensure project.description is set before publishing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| keeper-gradle-plugin/build.gradle.kts | Adds project description property for use in publishing metadata |
| gradle/plugins/src/main/kotlin/PublishingPlugin.kt | Replaces hardcoded description with project.description and adds validation check |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
538ad5e to
9c6ea62
Compare
|
Diffuse output: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.