Skip to content

Conversation

zlatan-g
Copy link

@zlatan-g zlatan-g commented Oct 20, 2025

After discussing with @chrisjsewell this PR was created to use check_needs_data to also validate remote jsons
(was previously indented and was only happening for the else case)

@zlatan-g zlatan-g requested a review from Copilot October 20, 2025 08:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.95%. Comparing base (4e10030) to head (f72853e).
⚠️ Report is 184 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
+ Coverage   86.87%   87.95%   +1.07%     
==========================================
  Files          56       70      +14     
  Lines        6532     9606    +3074     
==========================================
+ Hits         5675     8449    +2774     
- Misses        857     1157     +300     
Flag Coverage Δ
pytests 87.95% <100.00%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! Indeed it looks like a mistake

@chrisjsewell chrisjsewell changed the title 🔧 Fix check_needs_data not checking remote files 🔧 Fix check_needs_data not checking remote files Oct 20, 2025
@chrisjsewell chrisjsewell changed the title 🔧 Fix check_needs_data not checking remote files 🔧 Fix check_needs_data not checking remote files in needimport Oct 20, 2025
errors = check_needs_data(needs_import_list)
if errors.schema:
logger.info(
f"Schema validation errors detected in file {correct_need_import_path}:"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah actually correct_need_import_path is only available from the local file path if/esle branch, so this needs to now account for also pointing to the remote path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants