-
Notifications
You must be signed in to change notification settings - Fork 77
🔧 Fix check_needs_data
not checking remote files in needimport
#1557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1557 +/- ##
==========================================
+ Coverage 86.87% 87.95% +1.07%
==========================================
Files 56 70 +14
Lines 6532 9606 +3074
==========================================
+ Hits 5675 8449 +2774
- Misses 857 1157 +300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! Indeed it looks like a mistake
check_needs_data
not checking remote files
check_needs_data
not checking remote filescheck_needs_data
not checking remote files in needimport
errors = check_needs_data(needs_import_list) | ||
if errors.schema: | ||
logger.info( | ||
f"Schema validation errors detected in file {correct_need_import_path}:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah actually correct_need_import_path
is only available from the local file path if/esle branch, so this needs to now account for also pointing to the remote path
After discussing with @chrisjsewell this PR was created to use
check_needs_data
to also validate remote jsons(was previously indented and was only happening for the else case)