Skip to content

👌 Reset SN for testing #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

👌 Reset SN for testing #1448

wants to merge 1 commit into from

Conversation

ubmarco
Copy link
Member

@ubmarco ubmarco commented Apr 26, 2025

All SN test cases run in the same Python interpreter.
Each test case should see a SN state as it's loaded from disk.
This PR resets SN after test case execution in the test_app fixture.

The problem was a finding of #1441.

@ubmarco ubmarco changed the title 🧪 Reset SN for testing 👌 Reset SN for testing Apr 26, 2025
Copy link

codecov bot commented Apr 26, 2025

Codecov Report

Attention: Patch coverage is 80.18868% with 21 lines in your changes missing coverage. Please review.

Project coverage is 88.42%. Comparing base (4e10030) to head (eeada5b).
Report is 130 commits behind head on master.

Files with missing lines Patch % Lines
sphinx_needs/directives/needgantt.py 62.50% 3 Missing ⚠️
sphinx_needs/directives/needsequence.py 62.50% 3 Missing ⚠️
sphinx_needs/directives/needextract.py 71.42% 2 Missing ⚠️
sphinx_needs/directives/needlist.py 71.42% 2 Missing ⚠️
sphinx_needs/directives/needpie.py 75.00% 2 Missing ⚠️
sphinx_needs/directives/needservice.py 71.42% 2 Missing ⚠️
sphinx_needs/directives/needtable.py 66.66% 2 Missing ⚠️
sphinx_needs/directives/needbar.py 83.33% 1 Missing ⚠️
sphinx_needs/directives/needextend.py 80.00% 1 Missing ⚠️
sphinx_needs/directives/needimport.py 83.33% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
+ Coverage   86.87%   88.42%   +1.54%     
==========================================
  Files          56       62       +6     
  Lines        6532     7332     +800     
==========================================
+ Hits         5675     6483     +808     
+ Misses        857      849       -8     
Flag Coverage Δ
pytests 88.42% <80.18%> (+1.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ubmarco ubmarco requested a review from chrisjsewell April 26, 2025 10:44
@ubmarco ubmarco marked this pull request as ready for review April 26, 2025 10:44
@ubmarco ubmarco self-assigned this May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant