fix all positions #2151
Closed
fix all positions #2151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Parvinmh is attempting to deploy a commit to the Pean Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
binrysearch
reviewed
Nov 29, 2025
| | "bottom-middle-aligned"; | ||
| | "bottom-middle-aligned" | ||
| | "bottom-right-aligned"; | ||
| export type TooltipPosition = TooltipBasePosition | TooltipAlignment; |
Contributor
There was a problem hiding this comment.
Why are we introducing a new type for this? Why not keep all under the same type?
Contributor
Author
There was a problem hiding this comment.
They’re combined into TooltipPosition for a simple public API, but kept separate for correctness and maintainability.
| ? (containerOrWindow as HTMLElement).clientHeight | ||
| : (containerOrWindow as { width: number; height: number }).height; | ||
| const tW = tooltipWidth + 12; | ||
| const tH = tooltipHeight + 12; |
Contributor
There was a problem hiding this comment.
where number 12 is coming from?
Contributor
Author
There was a problem hiding this comment.
Arrow size (10px): extends beyond tooltip box
Safety margin (2px): prevents touching viewport edges
src/util/getOffset.ts
Outdated
| * @returns Element's position info | ||
| * Returns all scrollable parents up to document root | ||
| */ | ||
| function getScrollParents(el: HTMLElement): HTMLElement[] { |
Contributor
There was a problem hiding this comment.
How this was handled previously?
Parvinmh
force-pushed
the
fix/Position
branch
from
e331f76 to
ce0a43e
Compare
Parvinmh
force-pushed
the
fix/Position
branch
from
a2ec7a8 to
77ab5e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.