chore: configure clippy lints, improve unwrap usage#14
Draft
koloiyolo wants to merge 2 commits into
Draft
Conversation
koloiyolo
force-pushed
the
chore/add_clippy_rules
branch
from
fdbe2c0 to
d73989b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #12
This MR introduces a Clippy configuration intended to help detect existing
unwrap()usages in the codebase, with the goal of gradually replacing them with more descriptiveexpect()calls or proper error handling where appropriate.I decided to go with
warninstead ofdeny, because as You mentioned in #12, someunwraps are OK.Objectives of this MR: