Skip to content

RFC - Restore Subservice export for compatibility #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mokagio wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

RFC - Restore Subservice export for compatibility #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a0befd
Add enum export compatibility tests
mokagio Mar 15, 2026
3924a9f
Restore Subservice enum exports
mokagio Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/spacepackets/ecss/pus_17_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ class MessageSubtype(enum.IntEnum):
TM_REPLY = 2


Subservice = MessageSubtype


class Service17Tm(AbstractPusTm):
def __init__(
self,
Expand Down
3 changes: 3 additions & 0 deletions src/spacepackets/ecss/pus_3_hk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,6 @@ class MessageSubtype(enum.IntEnum):

TC_MODIFY_PARAMETER_REPORT_COLLECTION_INTERVAL = 31
TC_MODIFY_DIAGNOSTICS_REPORT_COLLECTION_INTERVAL = 32


Subservice = MessageSubtype
3 changes: 3 additions & 0 deletions src/spacepackets/ecss/pus_5_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ class MessageSubtype(enum.IntEnum):
TM_HIGH_SEVERITY_EVENT = 4
TC_ENABLE_EVENT_REPORTING = 5
TC_DISABLE_EVENT_REPORTING = 6


Subservice = MessageSubtype
14 changes: 14 additions & 0 deletions tests/ecss/test_message_subtype_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from unittest import TestCase

from spacepackets.ecss import pus_3_hk, pus_5_event, pus_17_test


class TestMessageSubtypeCompat(TestCase):
def test_service_17_exports_legacy_subservice_enum_alias(self):
self.assertIs(pus_17_test.Subservice, pus_17_test.MessageSubtype)

def test_service_3_exports_legacy_subservice_enum_alias(self):
self.assertIs(pus_3_hk.Subservice, pus_3_hk.MessageSubtype)

def test_service_5_exports_legacy_subservice_enum_alias(self):
self.assertIs(pus_5_event.Subservice, pus_5_event.MessageSubtype)
Loading