Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatting and version in export_modelica_loads #149

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

nllong
Copy link
Member

@nllong nllong commented Apr 28, 2024

Resolves #[issue number here]

n/a

Pull Request Description

Ran update measures and rubocop:auto_correct

[description here]

Checklist (Delete lines that don't apply)

  • Unit tests have been added or updated
  • Documentation has been modified appropriately
  • All ci tests pass (green)
  • An ISSUE has been created that this is addressing. Issues will get added to the Change Log when the change_log.rb script is run.
  • This branch is up-to-date with develop

@nllong nllong requested a review from vtnate April 28, 2024 22:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8870979172

Details

  • 29 of 99 (29.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.705%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/urbanopt/reporting/default_reports/scenario_power_distribution_cost.rb 28 98 28.57%
Totals Coverage Status
Change from base Build 7470732191: 0.0%
Covered Lines: 1161
Relevant Lines: 1767

💛 - Coveralls

Copy link
Collaborator

@vtnate vtnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<measure>
<schema_version>3.1</schema_version>
<schema_version>3.0</schema_version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno how this got changed to something OS doesn't play nicely with, but I'm glad it got standardized! ❤️

@vtnate vtnate merged commit f74155e into develop Apr 30, 2024
@vtnate vtnate deleted the formatting branch April 30, 2024 20:43
vtnate added a commit that referenced this pull request May 6, 2024
* Additional reporting tests (#147)

* wip: tests for distributed generation reports

* details so 2 more tests pass

* continuing to clean up merging dgen test

* fix how I instantiate the dgen class

* yet moar tests!

* remove testing print statements

* update formatting and version in export_modelica_loads (#149)

Co-authored-by: Nathan Moore <[email protected]>

* Update feature reports for Reopt v3 (#148)

* start of mods for v3

* update to remove `us_dollars` from reopt outputs

* change `_pct` to `_fraction`

* fix copy paste typo

---------

Co-authored-by: kflemin <[email protected]>

* Prep 0.10.0 (#150)

* bump to version 0.10.0

* update changelog from github automated output

* rubocop

* fix test after earlier refactor

* enable manually running CI on demand (once merged to develop)

---------

Co-authored-by: Nicholas Long <[email protected]>
Co-authored-by: kflemin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants