ESM, Howler y base64 assets #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdodino
approved these changes
Dec 30, 2025
Contributor
fdodino
left a comment
fdodino
left a comment
There was a problem hiding this comment.
banco fuerte esta movida, es la que va!!!
Bien ahí Ivo!!
| <script>var process = {};</script> | ||
| <link rel="stylesheet" href="game.css" /> | ||
| <script> | ||
| var process = {}; |
Contributor
There was a problem hiding this comment.
ahora que lo veo, no debería ser let process = {};? O la queremos así, hoisted?
no tengo ni idea qué hace acá
Contributor
Author
There was a problem hiding this comment.
Si tengo que adivinar esto debe ser por p5 que usa mucho las variables globales de node (malisimo). Pero realmente no tengo contexto, el que sabe de esto es @PalumboN
Contributor
There was a problem hiding this comment.
Eso estaba así porque sino rompía algo de p5, habría que probar sacándolo y viendo que todo funcione :P
PalumboN
approved these changes
Jan 14, 2026
Contributor
PalumboN
left a comment
PalumboN
left a comment
There was a problem hiding this comment.
Alto perriiiiiiii 🚀
Para mí debería exportarse el SocketGame para usarlo desde CLI y estamos 💯
src/index.ts
Outdated
| export * from './game/utils' No newline at end of file | ||
| export * from './game/utils.js' | ||
|
|
||
| export { LocalGame } from './game/game.js' No newline at end of file |
| keyboard.space().onPressDo({ | ||
| game.say(pepita, "Ouch") | ||
| // game.sound('musica.mp3').play() | ||
| game.sound('musica.mp3').play() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cambios para poder correr
LocalGameen una aplicacion React, que es lo que estuve laburando aca con la intencion de no tener que cargarLocalGamecomo parte del objetowindowsi no como una clase comun y corriente que existe en el mundo typescriptes2022/dist/web) sigue siendo commonjs (para no romper todos los uses que le damos), en un futuro probablemente deberiamos separar en 2 packages lo bundleado y el esm porque ahora el package debe estar pesando ~2x lo que deberiawindow), empezamos a usar HowlerA esto le falta lo que @fdodino propuso en #28 pero creo que puede ir por separado