Update QuotationSorting #725
Open
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessiocol
force-pushed
the
PT-5960-populate-quotationsorting-container
branch
from
97871f5 to
135fdea
Compare
andher1802
reviewed
Feb 3, 2025
| @@ -207,7 +207,10 @@ def choose_feasibility(self, feasibility_id: str, accepted_option_id: str) -> di | |||
|
|
|||
|
|
|||
| class QuotationSorting: | |||
There was a problem hiding this comment.
Just a question, non-binding, should we add unit tests for the new sorting criteria in here?
There was a problem hiding this comment.
thanks, I just expanded the test, please let me know your thoughts
CHANGELOG.md
Outdated
| @@ -29,6 +29,10 @@ You can check your current version with the following command: | |||
| ``` | |||
|
|
|||
| For more information, see [UP42 Python package description](https://pypi.org/project/up42-py/). | |||
| ## 2.2.0a23 | |||
| **Feb 3, 2025** | |||
| - Updated `QuotationSorting`. | |||
There was a problem hiding this comment.
NIT: Maybe "Add sorting fields to QuotationSorting"?
| @@ -207,7 +207,10 @@ def choose_feasibility(self, feasibility_id: str, accepted_option_id: str) -> di | |||
|
|
|||
|
|
|||
| class QuotationSorting: | |||
|
matheuspinheirosantos
approved these changes
Feb 14, 2025
andher1802
previously approved these changes
Feb 14, 2025
There was a problem hiding this comment.
I approved since @matheuspinheirosantos did and I think the merge rights is still not updated.
alessiocol
force-pushed
the
PT-5960-populate-quotationsorting-container
branch
from
33f7115 to
527cde7
Compare
|
jonathanBareket
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected sorting fields are added to
QuotationSorting.Checklist: