-
-
Notifications
You must be signed in to change notification settings - Fork 1
fix: disable benchmark runs for feature branches #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/0.0.7
Are you sure you want to change the base?
fix: disable benchmark runs for feature branches #492
Conversation
|
This does not solve the issue though, can you double check? |
|
@jonasstrehle I've updated the PR to correctly exclude feature branches. The workflow is now working as expected: Changes made:
The workflow will now:
|
.github/workflows/publish.yml
Outdated
| - uses: katyo/publish-crates@v2 | ||
|
|
||
| - name: Run cargo publish dry-run | ||
| run: cargo publish --dry-run --allow-dirty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the dry run here, we don't have any benefit in doing this, as we already perform the dry run in the release/xx branch as required action to be passed before we can merge.
|
Could you take a look at the two comments and also rebase this branch to the release/0.0.7 please? |
20822b1 to
cbf6a25
Compare
|
@jonasstrehle I've addressed all your feedback:
The PR is now ready for your review. All checks have passed, and the changes are up to date with the target branch. Changes Made:
Let me know if you need any further adjustments! |
Description
This PR modifies the PR benchmarks workflow to skip running benchmarks for feature branches, as they can be time-consuming and may clutter the benchmark history. Benchmarks will now only run for:
release/*)hotfix/*)Changes
Testing
Related Issues
Closes #463