Fix: mmap MAP_FAILED not handled correctly on POSIX#722
Open
DavIvek wants to merge 1 commit intounum-cloud:main-devfrom
Open
Fix: mmap MAP_FAILED not handled correctly on POSIX#722DavIvek wants to merge 1 commit intounum-cloud:main-devfrom
DavIvek wants to merge 1 commit intounum-cloud:main-devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On POSIX,
mmapreturnsMAP_FAILED ((void*)-1)on failure, notNULL: https://man7.org/linux/man-pages/man2/mmap.2.htmlTwo call sites were incorrectly treating the return value as nullable:
index_plugins.hpp: allocate()castmmapresult directly tobyte_t*without checkingMAP_FAILED, returning a garbage pointer instead ofnullptrbench.cpp: persisted_matrix_gtchecked== nullptrinstead of== MAP_FAILED,silently passing on failure and proceeding with an invalid pointer
Fix
Both are fixed to check MAP_FAILED before casting.