Skip to content

Define MAP_FAILED if not already defined#720

Open
markusalbertgraf wants to merge 1 commit intounum-cloud:mainfrom
markusalbertgraf:patch-1
Open

Define MAP_FAILED if not already defined#720
markusalbertgraf wants to merge 1 commit intounum-cloud:mainfrom
markusalbertgraf:patch-1

Conversation

@markusalbertgraf
Copy link
Contributor

#715 Add missing constant MAP_FAILED for Windows.
Can't test this, as I have not Windows. Just copied what others on github do.

unum-cloud#715 Add missing constant MAP_FAILED to Windows.
Can't test this, as I have not Windows.
@markusalbertgraf
Copy link
Contributor Author

markusalbertgraf commented Feb 28, 2026

Fixes #719 and is the solution of @bjornblissing

@anaslimem
Copy link

I will try it now and tell you if it works thank you :)

@anaslimem
Copy link

i think i need to wait for you for the next release!

@obfuscate
Copy link

obfuscate commented Mar 7, 2026

Hello there. Any chance to merge it? because right now it ruins compilation of tracy from vcpkg on windows:

build\windows-msvc-msbuild\vcpkg_installed\x64-windows\include\usearch/index_plugins.hpp(962): error C3861: 'MAP_FAILED': identifier not found
build\windows-msvc-msbuild\vcpkg_installed\x64-windows\include\usearch/index_plugins.hpp(962): note: the template instantiation context (the oldest one first) is
build\windows-msvc-msbuild\vcpkg_installed\x64-windows\include\usearch/index_plugins.hpp(878): note: while compiling class template 'unum::usearch::memory_mapping_allocator_gt'
build\windows-msvc-msbuild\vcpkg_installed\x64-windows\include\usearch/index_plugins.hpp(962): error C2065: 'MAP_FAILED': undeclared identifier

@ashvardanian
Copy link
Contributor

Gotcha, @obfuscate! I'll merge it in a 3-4 hours. Sorry it's taking a while, I'm trying to push the ashvardanian/SimSIMD#220 release through the line to merge it into USearch, but it seems like this patch is quite urgent 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants