Open
Conversation
madmax983
force-pushed
the
fix/rust-move-semantics
branch
2 times, most recently
from
30173d7 to
e978d87
Compare
madmax983
force-pushed
the
fix/rust-move-semantics
branch
from
1fd0268 to
a969821
Compare
Author
|
Reworked it, let me know if this way is better? |
Contributor
|
Thanks, @madmax983! I'll double check in a couple of days and will be happy to merge if everything is optimal 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(rust): call reserve() after heap allocation to prevent segfaults
Calling reserve() on stack-allocated index before moving to heap stores dangling pointers, causing crashes when Index is used in Rust structs, Box, Arc, or any moved context.
Move reserve() call to wrap() function after heap allocation.
Just as a reference this came up with trying to implement usearch in https://github.com/madmax983/GallifreyDB to replace hnsw_rs.