Add spans, take 2 #120
Merged
Add spans, take 2 #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some "real world" benchmarks, which are taken from https://github.com/AndreasMadsen/htmlparser-benchmark/tree/master/files.
The main abstraction is the new function `Emitter::move_position`. The `CallbackEmitter` uses this to track positions and spans. For that, the tokenizer has to do some more work and emit more events, so that the `Emitter` can track the position accurately. An alternative was to add a `Reader` parameter to all emitter methods, which can be used by `CallbackEmitter` to get spans from the reader. We decided for this approach as it introduces less breaking changes and clutter for the users which don't want to consume spans.
|
0.8.0 is out, thanks! |
This was referenced Aug 15, 2025
Closed
|
Thank you for this cool library and the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #119 which is superseeded by this.
I squashed the commits (if you want it to more split, please say so).
It would be nice, if you would not squash the two commits as the new benchmarks are rather large and make the other commit less nice to view (but this is not super important).