-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code coverage #942
Conversation
zubhub_frontend/zubhub/src/components/form/videoInput/VideoInput.jsx
Outdated
Show resolved
Hide resolved
zubhub_frontend/zubhub/src/components/form/imageInput/ImageInput.jsx
Outdated
Show resolved
Hide resolved
zubhub_frontend/zubhub/src/components/form/imageInput/ImageInput.jsx
Outdated
Show resolved
Hide resolved
zubhub_frontend/zubhub/src/components/form/imageInput/ImageInput.jsx
Outdated
Show resolved
Hide resolved
zubhub_frontend/zubhub/src/components/form/imageInput/ImageInput.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Mutombe, thanks for much for working on this! testing is something we are really lacking and I am glad someone is taking on that. I requested a couple of changes. Do you mind taking a look?
Removing extra spaces
Removing extra space
Removing extra space
Removing extra space
Roger that. |
hello @Mutombe, I see that you still have have of the things in the previous review in this patch. I'd advise you remove them so we can merge this. I can work you through the process of doing this if you'd like:
|
also ensure that your own copy of the repository is up to date |
Done |
Summary
This pull request addresses issue #886 by introducing comprehensive tests for five views in the Projects app. These tests ensure the reliability and correctness of the views, enhancing the overall quality and stability of the application.
Changes
The following changes have been made in this pull request:
Implemented tests for the
ProjectCreateAPIView
: These tests cover various scenarios related to project creation, validating inputs, handling permissions, and verifying the appropriate response codes and data.Implemented tests for the
ProjectUpdateAPIView
: These tests thoroughly examine the functionality of updating project details, including edge cases, error handling, and ensuring the proper behavior of the view under different circumstances.Implemented tests for the
ProjectDeleteAPIView
: These tests assess the behavior of the project deletion process, verifying that the appropriate permissions are enforced, confirming the correct response codes, and ensuring the database integrity is maintained.Implemented tests for the
ProjectDetailsAPIView
: These tests comprehensively evaluate the functionality of retrieving project details, covering different scenarios, handling various input cases, and validating the correctness of the returned data.Each of these test implementations incorporates thorough test coverage to safeguard against regressions and ensure the robustness of the Projects app.
By introducing these tests, we can confidently assert the reliability and stability of these critical views, mitigating potential issues and providing a more professional and polished experience for our users.
Please review the changes and provide your feedback.