Skip to content

fix: Prevent JSON serialization errors and accept keyword keys in tool properties #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vedang merged 1 commit into from
Jan 2, 2026
Merged

fix: Prevent JSON serialization errors and accept keyword keys in tool properties #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/io/modelcontext/clojure_sdk/server.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,17 @@
;;; Server Spec

(defn validate-spec!
"Validates the server-spec and throws if invalid.
Strips handler functions before logging to avoid JSON serialization errors."
[server-spec]
(when-not (specs/valid-server-spec? server-spec)
(let [msg "Invalid server-spec definition"]
(log/debug :msg msg :spec server-spec)
(let [msg "Invalid server-spec definition"
;; Strip handlers before logging to avoid JSON serialization errors
loggable-spec (-> server-spec
(update :tools (fn [tools] (mapv #(dissoc % :handler) tools)))
(update :prompts (fn [prompts] (mapv #(dissoc % :handler) prompts)))
(update :resources (fn [resources] (mapv #(dissoc % :handler) resources))))]
(log/debug :msg msg :spec loggable-spec)
(throw (ex-info msg (specs/explain-server-spec server-spec)))))
server-spec)

Expand Down
2 changes: 1 addition & 1 deletion src/io/modelcontext/clojure_sdk/specs.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@
;; Definition for a tool the client can call.
(s/def :tool/name string?)
(s/def :tool/description string?)
(s/def :tool/properties (s/map-of string? any?))
(s/def :tool/properties (s/map-of (s/or :str string? :kw keyword?) any?))
(s/def :tool/required (s/coll-of string?))
(s/def :schema/type #{"object"})
;; A JSON Schema object defining the expected parameters for the tool.
Expand Down