Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 7.0.1 release notes #238

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Add 7.0.1 release notes #238

merged 1 commit into from
Feb 25, 2025

Conversation

ljm42
Copy link
Member

@ljm42 ljm42 commented Feb 25, 2025

Before Submitting This PR, Please Ensure You Have Completed The Following:

  1. Are internal links to wiki documents using relative file links?
  2. Are all new documentation files lowercase, with dash separated names (ex. unraid-os.mdx)?
  3. Are all assets (images, etc), located in an assets/ subfolder next to the .md/mdx files?
  4. Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  5. Is the build succeeding?

Summary by CodeRabbit

  • Bug Fixes
    • Resolved a significant security issue with Tailscale integration when using certain container network configurations.
    • Enhanced overall stability by addressing issues in Docker management, memory leaks, remote share access, and VM functionality.
    • Updated key system components to mitigate security vulnerabilities.

These improvements are part of the version 7.0.1 release, ensuring a safer and more stable user experience.

Copy link
Contributor

coderabbitai bot commented Feb 25, 2025

Walkthrough

This update to the release notes documents version 7.0.1 of the software. It outlines a security and bug fix release that aggregates all patches from version 7.0.0. The most notable change is the update to the Tailscale integration, which now prevents its use on Host mode containers and disallows new containers with a "Container" network type from using it. Additionally, the release notes detail various bug fixes, improvements to Docker management, memory leak resolutions, VM-related issues, and kernel as well as base distribution package updates.

Changes

File Path Summary
docs/unraid-os/release-notes/7.0.1.md Introduces version 7.0.1 release notes, detailing security fixes (especially for Tailscale integration), along with various bug fixes and improvements in Docker management, memory leak resolution, VM issues, and kernel/base distribution updates.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Container
    participant TailscaleService
    User->>Container: Start container with Tailscale integration
    Container->>Container: Check network type configuration
    alt Host Mode
        Container->>User: Reject Tailscale integration & provide error advice
    else Non-Host Mode
        Container->>TailscaleService: Enable integration
        TailscaleService-->>Container: Confirm integration
        Container->>User: Proceed with Tailscale functionality
    end
Loading

Possibly related PRs

Poem

I’m a bunny with a coding flair,
Hopping through fixes with utmost care.
Tailscale’s now a bit more refined,
Host mode issues left far behind.
With every patch my heart does cheer—
Leaping into a secure frontier!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ljm42 ljm42 force-pushed the add-7-0-1-release-notes branch from 4669eb7 to 343972b Compare February 25, 2025 23:34
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🔭 Outside diff range comments (1)
docs/unraid-os/release-notes/7.0.1.md (1)

73-73: ⚠️ Potential issue

Remove Stray Number at End of File

Line 73 shows an extraneous “73” that likely was left in by accident. Please remove it to maintain document cleanliness.

🧹 Nitpick comments (3)
docs/unraid-os/release-notes/7.0.1.md (3)

40-42: Reword "fix" Line for Improved Clarity

Line 42 currently reads:
* fix issue with blank Discard field on vDisk
Consider rewording to improve formality and consistency, for example:
* Fix blank Discard field on vDisk
This small change makes the entry clearer.

Proposed Diff:

-* fix issue with blank Discard field on vDisk
+* Fix blank Discard field on vDisk
🧰 Tools
🪛 LanguageTool

[style] ~42-~42: Consider using a different verb for a more formal wording.
Context: ...reates a new share with the VM name * fix issue with blank Discard field on vDisk...

(FIX_RESOLVE)


43-43: Improve Grammar for Driver Blacklisting

The bullet on line 43 can be rephrased for clarity. Consider inserting a "to" for grammatical correctness. For example:
* Blacklist the cdc_ether driver to prevent issues with IPMI NICs on certain motherboards

Proposed Diff:

-* Blacklist the `cdc_ether` driver prevent issues with IPMI NICs on certain motherboards
+* Blacklist the `cdc_ether` driver to prevent issues with IPMI NICs on certain motherboards

54-54: Remove Trailing Punctuation in Heading

Markdownlint recommends removing trailing punctuation from headings. Change “### Base distro:” to “### Base distro”.

Proposed Diff:

-### Base distro:
+### Base distro
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

54-54: Trailing punctuation in heading
Punctuation: ':'

(MD026, no-trailing-punctuation)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4d596c9 and 343972b.

📒 Files selected for processing (1)
  • docs/unraid-os/release-notes/7.0.1.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/unraid-os/release-notes/7.0.1.md

[duplication] ~36-~36: Possible typo: you repeated a word.
Context: ...x mc not preserving cwd upon F10 exit * mover * mover was not moving shares with spaces in th...

(ENGLISH_WORD_REPEAT_RULE)


[style] ~42-~42: Consider using a different verb for a more formal wording.
Context: ...reates a new share with the VM name * fix issue with blank Discard field on vDisk...

(FIX_RESOLVE)

🪛 markdownlint-cli2 (0.17.2)
docs/unraid-os/release-notes/7.0.1.md

54-54: Trailing punctuation in heading
Punctuation: ':'

(MD026, no-trailing-punctuation)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (4)
docs/unraid-os/release-notes/7.0.1.md (4)

1-2: Header Version and Date Verification

The title and date appear correctly formatted. Please ensure these are kept up-to-date per release.


3-7: Upgrade Notes Section Clarity

The "Upgrade notes" section clearly explains the nature of the security and bug fix release. No issues noted.


9-16: Known Issues and Rolling Back Sections

The sections for "Known issues" and "Rolling back" contain clear and properly linked information. Ensure that the linked file 7.0.0.md remains accurate.


17-27: Bug Fixes and Improvements Overview

The detailed listing under "Changes vs. [7.0.0]" is thorough and well-structured. The Tailscale integration details are clearly communicated.

Comment on lines +35 to +38
* Fix mc not preserving cwd upon F10 exit
* mover
* mover was not moving shares with spaces in the name from array to pool
* mover was not handling hard links properly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Duplicate "mover" Bullet

Line 36 contains a standalone bullet "* mover" that appears redundant given the subsequent detailed entries (lines 37–38). It is recommended to remove or merge this line with its sub-items for clarity.

Proposed Diff:

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools
🪛 LanguageTool

[duplication] ~36-~36: Possible typo: you repeated a word.
Context: ...x mc not preserving cwd upon F10 exit * mover * mover was not moving shares with spaces in th...

(ENGLISH_WORD_REPEAT_RULE)

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-238.d1o5s833kbd339.amplifyapp.com

@ljm42 ljm42 merged commit e369f41 into main Feb 25, 2025
2 of 3 checks passed
@ljm42 ljm42 deleted the add-7-0-1-release-notes branch February 25, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant