-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 7.0.1 release notes #238
Conversation
WalkthroughThis update to the release notes documents version 7.0.1 of the software. It outlines a security and bug fix release that aggregates all patches from version 7.0.0. The most notable change is the update to the Tailscale integration, which now prevents its use on Host mode containers and disallows new containers with a "Container" network type from using it. Additionally, the release notes detail various bug fixes, improvements to Docker management, memory leak resolutions, VM-related issues, and kernel as well as base distribution package updates. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Container
participant TailscaleService
User->>Container: Start container with Tailscale integration
Container->>Container: Check network type configuration
alt Host Mode
Container->>User: Reject Tailscale integration & provide error advice
else Non-Host Mode
Container->>TailscaleService: Enable integration
TailscaleService-->>Container: Confirm integration
Container->>User: Proceed with Tailscale functionality
end
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
4669eb7
to
343972b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
docs/unraid-os/release-notes/7.0.1.md (1)
73-73
:⚠️ Potential issueRemove Stray Number at End of File
Line 73 shows an extraneous “73” that likely was left in by accident. Please remove it to maintain document cleanliness.
🧹 Nitpick comments (3)
docs/unraid-os/release-notes/7.0.1.md (3)
40-42
: Reword "fix" Line for Improved ClarityLine 42 currently reads:
* fix issue with blank Discard field on vDisk
Consider rewording to improve formality and consistency, for example:
* Fix blank Discard field on vDisk
This small change makes the entry clearer.Proposed Diff:
-* fix issue with blank Discard field on vDisk +* Fix blank Discard field on vDisk🧰 Tools
🪛 LanguageTool
[style] ~42-~42: Consider using a different verb for a more formal wording.
Context: ...reates a new share with the VM name * fix issue with blank Discard field on vDisk...(FIX_RESOLVE)
43-43
: Improve Grammar for Driver BlacklistingThe bullet on line 43 can be rephrased for clarity. Consider inserting a "to" for grammatical correctness. For example:
* Blacklist the
cdc_etherdriver to prevent issues with IPMI NICs on certain motherboards
Proposed Diff:
-* Blacklist the `cdc_ether` driver prevent issues with IPMI NICs on certain motherboards +* Blacklist the `cdc_ether` driver to prevent issues with IPMI NICs on certain motherboards
54-54
: Remove Trailing Punctuation in HeadingMarkdownlint recommends removing trailing punctuation from headings. Change “### Base distro:” to “### Base distro”.
Proposed Diff:
-### Base distro: +### Base distro🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
54-54: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/unraid-os/release-notes/7.0.1.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/unraid-os/release-notes/7.0.1.md
[duplication] ~36-~36: Possible typo: you repeated a word.
Context: ...x mc not preserving cwd upon F10 exit * mover * mover was not moving shares with spaces in th...
(ENGLISH_WORD_REPEAT_RULE)
[style] ~42-~42: Consider using a different verb for a more formal wording.
Context: ...reates a new share with the VM name * fix issue with blank Discard field on vDisk...
(FIX_RESOLVE)
🪛 markdownlint-cli2 (0.17.2)
docs/unraid-os/release-notes/7.0.1.md
54-54: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (4)
docs/unraid-os/release-notes/7.0.1.md (4)
1-2
: Header Version and Date VerificationThe title and date appear correctly formatted. Please ensure these are kept up-to-date per release.
3-7
: Upgrade Notes Section ClarityThe "Upgrade notes" section clearly explains the nature of the security and bug fix release. No issues noted.
9-16
: Known Issues and Rolling Back SectionsThe sections for "Known issues" and "Rolling back" contain clear and properly linked information. Ensure that the linked file
7.0.0.md
remains accurate.
17-27
: Bug Fixes and Improvements OverviewThe detailed listing under "Changes vs. [7.0.0]" is thorough and well-structured. The Tailscale integration details are clearly communicated.
* Fix mc not preserving cwd upon F10 exit | ||
* mover | ||
* mover was not moving shares with spaces in the name from array to pool | ||
* mover was not handling hard links properly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Duplicate "mover" Bullet
Line 36 contains a standalone bullet "* mover" that appears redundant given the subsequent detailed entries (lines 37–38). It is recommended to remove or merge this line with its sub-items for clarity.
Proposed Diff:
Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 LanguageTool
[duplication] ~36-~36: Possible typo: you repeated a word.
Context: ...x mc not preserving cwd upon F10 exit * mover * mover was not moving shares with spaces in th...
(ENGLISH_WORD_REPEAT_RULE)
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Before Submitting This PR, Please Ensure You Have Completed The Following:
Summary by CodeRabbit
These improvements are part of the version 7.0.1 release, ensuring a safer and more stable user experience.