-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update storage-management.md #210
Conversation
WalkthroughThe document Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docs/unraid-os/manual/storage-management.md (1)
1483-1483
: LGTM! The clarification about optional physical removal is helpful.Adding "(optional)" to the physical disk removal step improves clarity and maintains consistency with the "Replace a disk from array" section. This helps users understand that physical removal isn't mandatory for the replacement process.
Consider adding a brief note explaining why physical removal might be desired (e.g., for hardware inspection, RMA purposes) versus when it can be skipped.
-2. (optional) Physically detach the disk from your system you wish to remove. +2. (optional) Physically detach the disk from your system you wish to remove. This step is only necessary if you need to inspect the hardware or return the disk for RMA; otherwise, you can proceed with the logical replacement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
In `Replace a disk in a pool` section, add `optional` to physically remove the disk from server
In
Replace a disk in a pool
section, addoptional
to physically remove the disk from serverI don't think this is required. (right?)
In replace a disk from array section, it also only specified that disk-to-be-replaced should be unassigned, and did not require it to be physically removed.
Summary by CodeRabbit