Skip to content

Conversation

xon52
Copy link

@xon52 xon52 commented Oct 11, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds cursor-pointer class to the slider component to improve UX by visually indicating that both the slider track and thumb are interactive elements.

Changes:

  • Added cursor-pointer to SliderTrack component in all styles
  • Added cursor-pointer to SliderThumb component in all styles
  • Updated registry for both default and new-york styles
  • Updated v4 registry

Files Modified:

  • apps/www/src/registry/default/ui/slider/Slider.vue
  • apps/www/src/registry/new-york/ui/slider/Slider.vue
  • apps/v4/registry/new-york-v4/ui/slider/Slider.vue

πŸ“Έ Screenshots (if appropriate)

Recording.2025-10-12.090527.mp4

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sadeghbarati
Copy link
Collaborator

V4 registry of main shadcn ui: https://ui.shadcn.com/docs/components/slider

V3 Registry (legacy docs): https://v3.shadcn.com/docs/components/slider

Both slider track cursor is default

@xon52
Copy link
Author

xon52 commented Oct 12, 2025

Thanks for taking a look @sadeghbarati . I'm not sure what you are saying? Must shadcn-vue stay matched with shadcn? Or are you just making a comment?

It may be more controversial than I thought. I felt it was an obvious ui oversight. When using it without a cursor it is easy to miss it when you click as you cannot see when your cursor is on the right spot.

@sadeghbarati
Copy link
Collaborator

Yes we need to match the main shadcn ui

@xon52
Copy link
Author

xon52 commented Oct 14, 2025

I raised a corresponding change with shadcn ui: shadcn-ui/ui#8437

Looking at their backlog of PR's I don't have high hopes, but I'll keep an eye on it for as long as this PR is left open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants