Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: In-app purchases #2966

Closed
wants to merge 1 commit into from
Closed

feat: In-app purchases #2966

wants to merge 1 commit into from
+201 −15

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Apr 8, 2020 •
edited
Loading

GitHub Issue (If applicable): closes #2965

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

In-app purchases are not supported

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

@gitpod-io
Copy link

gitpod-io bot commented Apr 8, 2020

nventive-devops
nventive-devops reviewed Apr 8, 2020
View reviewed changes
src/Uno.UWPSyncGenerator/Generator.cs Outdated
@@ -68,6 +68,7 @@ public virtual void Build(string basePath, string baseName, string sourceAssembl
var origins = from externalRedfs in _referenceCompilation.ExternalReferences
where Path.GetFileNameWithoutExtension(externalRedfs.Display).StartsWith("Windows.Foundation")
|| Path.GetFileNameWithoutExtension(externalRedfs.Display).StartsWith("Windows.Phone.PhoneContract")
|| Path.GetFileNameWithoutExtension(externalRedfs.Display).StartsWith("Windows.Services.Store.StoreContract")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Change this call to 'Path.GetFileNameWithoutExtension(externalRedfs.Display).StartsWith' to an overload that accepts a 'StringComparison' as a parameter.

nventive-devops
nventive-devops reviewed Apr 8, 2020
View reviewed changes
src/Uno.UWP/Services/Store/Internal/SKProductExtensions.cs

private string GetFormattedPrice(this SKProduct product)
{
if (product?.PriceLocale == null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Add curly braces around the nested statement(s) in this 'if' block.

@MartinZikmund MartinZikmund self-assigned this Apr 9, 2020
@CLAassistant
Copy link

CLAassistant commented Jun 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@listepo
Copy link

listepo commented Mar 10, 2022

@MartinZikmund looks very interesting, any news?

@MartinZikmund
Copy link
Member Author

@listepo I got into other stuff, but I am trying to close down older PRs continuously, so hopefully won't take long for this one!

@listepo
Copy link

listepo commented May 26, 2022

@MartinZikmund thanks, I think this feature will help attract smaller developers like me who need monetization

@gitpod-io
Copy link

gitpod-io bot commented Jul 4, 2022

@MartinZikmund MartinZikmund changed the title [WIP] feat: In-app purchases [Blocked] feat: In-app purchases Sep 14, 2022
@listepo
Copy link

listepo commented Jan 23, 2024

@MartinZikmund any news?

@trydalch
Copy link

trydalch commented Sep 18, 2024 •
edited
Loading

Is this still blocked? And on what?

I saw this discussion alluding to in-app purchases here: #15378

Is it already possible to do in-app purchases on mobile?

@MartinZikmund MartinZikmund changed the title [Blocked] feat: In-app purchases feat: In-app purchases Sep 19, 2024
@github-actions github-actions bot added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform labels Sep 27, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-2966/index.html

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days.

@github-actions github-actions bot added the stale This item has been marked as stale and will be closed if there is no activity. label Jan 29, 2025
@MartinZikmund MartinZikmund removed the stale This item has been marked as stale and will be closed if there is no activity. label Jan 31, 2025
@MartinZikmund
Copy link
Member Author

Closing in favor of a new PR

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2025

⚠️ The sha of the head commit of this PR conflicts with #19399. Mergify cannot evaluate rules on this PR. ⚠️

@unodevops
Copy link
Contributor

⚠️⚠️ The build 153805 has failed on Uno.UI - docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventive-devops nventive-devops nventive-devops left review comments

Assignees

@MartinZikmund MartinZikmund

Labels
platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Epic] Add support for in-app purchases
6 participants
@MartinZikmund @CLAassistant @listepo @trydalch @unodevops @nventive-devops