fix: Fix possible invalid error message #21623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the VS extension logs an invalid timeout error message when the dev-server takes longer than expected to connect back to the IDE. The root cause was that the IDE channel was being initialized too late in the dev-server startup process (after add-ins resolution), causing the VS extension to timeout prematurely.
Key Changes:
- Increased the connection timeout threshold from 5 seconds to 10 seconds in the VS extension
- Moved IDE channel initialization earlier in the dev-server startup sequence to occur before add-in resolution
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Uno.UI.RemoteControl.VS/EntryPoint.cs |
Doubled the timeout delay from 5 to 10 seconds with clarifying comment |
src/Uno.UI.RemoteControl.Host/Program.cs |
Moved IDE channel registration and initialization from host services to global services, enabling earlier connection |
src/Uno.UI.RemoteControl.Host/IDEChannel/IdeChannelServer.cs |
Added comment clarifying keep-alive timing expectations |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jeromelaban
approved these changes
Oct 16, 2025
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21623/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21623/wasm-skia-net9/index.html |
|
|
ajpinedam
approved these changes
Oct 17, 2025
dr1rrb
force-pushed
the
dev/dr/devSrvIdeChanTimeout
branch
from
9afdcf1 to
45d8959
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21623/docs/index.html |
|
|
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21623/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21623/docs/index.html |
|
|
dr1rrb
force-pushed
the
dev/dr/devSrvIdeChanTimeout
branch
from
ccf984b to
93cf7ab
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21623/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21623/wasm-skia-net9/index.html |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21623/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21623/wasm-skia-net9/index.html |
|
The build 179093 found UI Test snapshots differences: Details
|
|
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21623/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21623/docs/index.html |
|
The build 179209 found UI Test snapshots differences: Details
|
|
|
MartinZikmund
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21622
🐞 Bugfix
Possible invalid error message in logs / output
What is the current behavior? 🤔
The dev-server connects back to the IDE only once it's fully setup, including after the add-ins has been resolved, which might take a while. This drives the VS extension to assume something went wrong as it didn't get any news from the dev-server in the given delay.
What is the new behavior? 🚀
IDE channel is enable much earlier.
PR Checklist ✅
Screenshots Compare Test Runresults.