fix: Remove empty RestoreBindings and ClearBindings #13046 #21554

mohamed-osman-se · 2025-10-02T15:40:24Z

This PR removes empty RestoreBindings and ClearBindings methods from DependencyObjectStore.Binder
and adjusts the generated code in DependencyObjectGenerator.

Addresses #13046

CLAassistant · 2025-10-02T15:40:37Z

All committers have signed the CLA.

unodevops · 2025-10-02T16:00:10Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21554/docs/index.html

build/PackageDiffIgnore.xml

src/SourceGenerators/Uno.UI.SourceGenerators/DependencyObject/DependencyObjectGenerator.cs

unodevops · 2025-10-03T07:50:15Z

⚠️⚠️ The build 177648 has failed on Uno.UI - docs.

unodevops · 2025-10-03T07:55:34Z

⚠️⚠️ The build 177649 has failed on Uno.UI - CI.

Xiaoy312

you would need to update the last commit title to conform to conventional commits
ideally, you should rebase and squash them all into a single commit

....UI.SourceGenerators.Tests/DependencyObjectGeneratorTests/Given_DependencyObjectGenerator.cs

Copilot

Pull Request Overview

This PR removes empty RestoreBindings() and ClearBindings() methods that were previously kept for binary compatibility but contained no implementation. The changes clean up unused code by removing these obsolete methods from both the DependencyObjectStore.Binder class and the generated code in DependencyObjectGenerator.

Key changes:

Removed empty RestoreBindings() and ClearBindings() methods from DependencyObjectStore.Binder
Updated code generator to stop generating obsolete binding methods
Added package diff ignore entries for the removed methods to maintain compatibility tracking

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`src/Uno.UI/UI/Xaml/DependencyObjectStore.Binder.cs`	Removed empty `RestoreBindings()` and `ClearBindings()` methods with their documentation
`src/SourceGenerators/Uno.UI.SourceGenerators/DependencyObject/DependencyObjectGenerator.cs`	Removed code generation for obsolete `ClearBindings()` and `RestoreBindings()` methods
`src/Uno.UI/UI/Xaml/IFrameworkElementImplementation.UIKit.tt`	Removed call to `ClearBindings()` method
`src/SourceGenerators/Uno.UI.SourceGenerators.Tests/DependencyObjectGeneratorTests/Given_DependencyObjectGenerator.cs`	Updated test expectations to reflect removal of obsolete methods and cleaned up formatting
`build/PackageDiffIgnore.xml`	Added ignore entries for removed methods to track API changes for version 6.2

unodevops · 2025-10-04T19:02:11Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21554/wasm-skia-net9/index.html

unodevops · 2025-10-04T19:02:16Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21554/docs/index.html

Xiaoy312 · 2025-10-06T14:47:45Z

build/PackageDiffIgnore.xml

+            <Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.ClearBindings()" reason="Removed in Uno 6.2" />
+            <Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.RestoreBindings()" reason="Removed in Uno 6.2" />


need a regex here, since the methods are code-generated on multiple classes

Suggested change

<Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.ClearBindings()" reason="Removed in Uno 6.2" />

<Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.RestoreBindings()" reason="Removed in Uno 6.2" />

<Member fullName="System\.Void .+\.(Clear|Restore)Bindings()" reason="Removed in Uno 6.2" />

Xiaoy312 · 2025-10-06T14:48:34Z

build/PackageDiffIgnore.xml

 			<Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.add_DataContextChanged(Windows.Foundation.TypedEventHandler`2&lt;Microsoft.UI.Xaml.FrameworkElement,Microsoft.UI.Xaml.DataContextChangedEventArgs&gt; value)" reason="Not present in WinAppSDK 1.2" />
 			<Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.remove_DataContextChanged(Windows.Foundation.TypedEventHandler`2&lt;Microsoft.UI.Xaml.FrameworkElement,Microsoft.UI.Xaml.DataContextChangedEventArgs&gt; value)" reason="Not present in WinAppSDK 1.2" />
-			<Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.ClearBindings()" reason="Not present in WinAppSDK 1.2" />
+	        <Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.ClearBindings()" reason="Not present in WinAppSDK 1.2" />


avoid whitespace changes if possible

Suggested change

<Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.ClearBindings()" reason="Not present in WinAppSDK 1.2" />

<Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.ClearBindings()" reason="Not present in WinAppSDK 1.2" />

remember to rebase squash after, otherwise it is still gonna stain the history

Xiaoy312 · 2025-10-06T14:48:46Z

build/PackageDiffIgnore.xml

 	</IgnoreSet>
 	<IgnoreSet baseVersion="6.1">
-		<Types>
+	    <Types>


Suggested change

<Types>

<Types>

Xiaoy312 · 2025-10-06T14:58:11Z

....UI.SourceGenerators.Tests/DependencyObjectGeneratorTests/Given_DependencyObjectGenerator.cs

https://dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=177761&view=logs&j=f63c6d40-e6cc-5158-041c-5ecaeb969bfb&t=dd05ac6d-5f8e-575b-7053-261df9674ec3&s=1ca05b26-5479-52b6-b481-8cd3b39f1708
test arent passing
just remove only of Clear/ResumeBindings and their attributes/comments, and keep everything else the same, whitespace included

Xiaoy312 · 2025-10-06T14:58:36Z

src/Uno.UI/UI/Xaml/DependencyObjectStore.Binder.cs

-		{
-
-		}



might as well, get rid of this extra empty line

Suggested change

unodevops · 2025-10-06T19:39:46Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21554/docs/index.html

unodevops · 2025-10-06T19:39:53Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21554/wasm-skia-net9/index.html

github-actions bot added area/code-generation Categorizes an issue or PR as relevant to code generation area/build Categorizes an issue or PR as relevant to build infrastructure labels Oct 2, 2025

Xiaoy312 reviewed Oct 2, 2025

View reviewed changes

build/PackageDiffIgnore.xml Show resolved Hide resolved

src/SourceGenerators/Uno.UI.SourceGenerators/DependencyObject/DependencyObjectGenerator.cs Outdated Show resolved Hide resolved

Xiaoy312 reviewed Oct 3, 2025

View reviewed changes

....UI.SourceGenerators.Tests/DependencyObjectGeneratorTests/Given_DependencyObjectGenerator.cs Outdated Show resolved Hide resolved

mohamed-osman-se force-pushed the fix/remove-empty-bindings branch from ee62d5f to 8f0ab14 Compare October 4, 2025 18:43

carldebilly requested a review from Copilot October 4, 2025 18:54

Copilot AI reviewed Oct 4, 2025

View reviewed changes

carldebilly approved these changes Oct 4, 2025

View reviewed changes

Xiaoy312 reviewed Oct 6, 2025

View reviewed changes

fix: remove empty RestoreBindings and cleanup

fad9620

mohamed-osman-se force-pushed the fix/remove-empty-bindings branch from 8f0ab14 to fad9620 Compare October 6, 2025 19:19

		<Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.ClearBindings()" reason="Removed in Uno 6.2" />
		<Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.RestoreBindings()" reason="Removed in Uno 6.2" />

	<Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.ClearBindings()" reason="Removed in Uno 6.2" />
	<Member fullName="System.Void Microsoft.UI.Xaml.Controls.ElementFactory.RestoreBindings()" reason="Removed in Uno 6.2" />
	<Member fullName="System\.Void .+\.(Clear\|Restore)Bindings()" reason="Removed in Uno 6.2" />

fix: Remove empty RestoreBindings and ClearBindings #13046 #21554

Are you sure you want to change the base?

fix: Remove empty RestoreBindings and ClearBindings #13046 #21554

Conversation

mohamed-osman-se commented Oct 2, 2025

Uh oh!

CLAassistant commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

unodevops commented Oct 2, 2025

Uh oh!

Uh oh!

Uh oh!

unodevops commented Oct 3, 2025

Uh oh!

unodevops commented Oct 3, 2025

Uh oh!

Xiaoy312 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

unodevops commented Oct 4, 2025

Uh oh!

unodevops commented Oct 4, 2025

Uh oh!

Xiaoy312 Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Xiaoy312 Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Xiaoy312 Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Xiaoy312 Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Xiaoy312 Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

unodevops commented Oct 6, 2025

Uh oh!

unodevops commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Oct 2, 2025 •

edited

Loading