Skip to content

Conversation

@MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Sep 24, 2025

GitHub Issue: closes #12839

PR Type: ✨ Feature, 🐞 Bugfix

What is the current behavior? πŸ€”

  • Generic.xaml is significantly outdated

What is the new behavior? πŸš€

  • Updating to latest Generic.xaml from WinUI

PR Checklist βœ…

Please check if your PR fulfills the following requirements:

Other information ℹ️

Copilot AI review requested due to automatic review settings September 24, 2025 09:26
@MartinZikmund MartinZikmund changed the title feat: Replace Generic.xaml resources with WinUI styles [WIP] feat: Replace Generic.xaml resources with WinUI styles Sep 24, 2025
@github-actions github-actions bot added the area/code-generation Categorizes an issue or PR as relevant to code generation label Sep 24, 2025
@MartinZikmund MartinZikmund marked this pull request as draft September 24, 2025 09:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces Generic.xaml resources with WinUI styles by removing platform-specific style declarations from TwoPaneView and ScrollViewer/ScrollBar XAML files and improving error messaging in the XAML generator.

  • Removes entire TwoPaneView_v1.xaml and TwoPaneView_rs1.xaml resource files
  • Eliminates platform-specific style declarations from ScrollViewer and ScrollBar XAML files
  • Enhances error messaging in XamlFileGenerator to include property and type information

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
TwoPaneView_v1.xaml Complete removal of TwoPaneView style definitions and resource dictionary
TwoPaneView_rs1.xaml Complete removal of TwoPaneView style definitions (already commented out)
ScrollViewer.xaml Removes platform-specific style declarations at end of file
ScrollBar.xaml Removes platform-specific style declarations at end of file
XamlFileGenerator.cs Improves error message to include property name and type information

@unodevops
Copy link
Contributor

πŸ€– Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21513/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

πŸ€– Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21513/docs/index.html

@unodevops
Copy link
Contributor

πŸ€– Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21513/wasm-skia-net9/index.html

@unodevops
Copy link
Contributor

πŸ€– Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21513/docs/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/code-generation Categorizes an issue or PR as relevant to code generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update base styles to match latest SDK

3 participants