-
Notifications
You must be signed in to change notification settings - Fork 821
[WIP] feat: Replace Generic.xaml resources with WinUI styles
#21513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Generic.xaml resources with WinUI stylesGeneric.xaml resources with WinUI styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces Generic.xaml resources with WinUI styles by removing platform-specific style declarations from TwoPaneView and ScrollViewer/ScrollBar XAML files and improving error messaging in the XAML generator.
- Removes entire TwoPaneView_v1.xaml and TwoPaneView_rs1.xaml resource files
- Eliminates platform-specific style declarations from ScrollViewer and ScrollBar XAML files
- Enhances error messaging in XamlFileGenerator to include property and type information
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TwoPaneView_v1.xaml | Complete removal of TwoPaneView style definitions and resource dictionary |
| TwoPaneView_rs1.xaml | Complete removal of TwoPaneView style definitions (already commented out) |
| ScrollViewer.xaml | Removes platform-specific style declarations at end of file |
| ScrollBar.xaml | Removes platform-specific style declarations at end of file |
| XamlFileGenerator.cs | Improves error message to include property name and type information |
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
Show resolved
Hide resolved
|
π€ Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21513/wasm-skia-net9/index.html |
|
π€ Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21513/docs/index.html |
686dacc to
97455ff
Compare
|
π€ Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21513/wasm-skia-net9/index.html |
|
π€ Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21513/docs/index.html |
GitHub Issue: closes #12839
PR Type: β¨ Feature, π Bugfix
What is the current behavior? π€
Generic.xamlis significantly outdatedWhat is the new behavior? π
Generic.xamlfrom WinUIPR Checklist β
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information βΉοΈ