-
Notifications
You must be signed in to change notification settings - Fork 821
Docs(docfx): update docfx build locally guide and apply xref links #19722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Docs(docfx): update docfx build locally guide and apply xref links #19722
Conversation
|
|
|
The markdown linting pipeline in this case would be greatly more helpful if it would also lint and suggest the solution for image video and links like relative paths and so on before the intending and spaces checks👍🤔 |
|
|
|
Currently on Fixing a regex bug, then I will send the updated commits. |
|
Does a include of Pester tests required check the ui tests checkbook above? |
|
@DevTKSS Thank you so much for the Pull Request ❤️ |
|
Status update: Things might to consider for add able tests and function for uid-xref links:
Currently checking on the dot sourcing third script now which should be last before again check on the main script which uses them. The dot sourcing one might be the most difficult one to setup test for because it has no actual function definition right now, just what it should execute. If it works but test setup has still trouble with its validation I would consider updating the related docs on it and commit to the remote branch so its review-able and maybe get a overseen solution for this. Since I did add those md files, I did sort them into directory and recognized that not really matching and seperated directorys. Seems like there is the main contributing one and the uno-development one which mainly contains all of the files nested in toc contributing😅 And I am thinking of, if the scripts might be better places to the testscrips folder instead(paths naturally fitted) to not cloud the documentation itself? |
|
@agneszitte @MartinZikmund commited to remote, unable to fix the Import-TocCheckerUtils.Test.ps1 to pass the check of Get-MarkdownHeader function, while it passed the dot-sourcing before. checking this here: It should have been able to get it from my point of view. |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
|
ToDo List to be checked:
|
doc/articles/contributing/guidelines/creating-ps-pester-tests.md
Outdated
Show resolved
Hide resolved
doc/articles/contributing/guidelines/creating-ps-pester-tests.md
Outdated
Show resolved
Hide resolved
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
|
work still in progress |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
1 similar comment
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
dcc12c5 to
8d6e32f
Compare
|
|
|
|
|
checked the "Run spell checking" pipeline problems, seems the CI needs some external help to ignore this or tell me and I switch the xref Names there, but since that are not my created ones and most likly be linked at some places, I would prefer decision from the team for this... Lines: Post Edit Note: Renaming has been applyed for xref of 1-3, others got added to cspell. See this commit for details |
|
|
|
|
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19722/index.html |
Rider Android Support is reported as incompatible as of 06.02.2025 should get checked and until then removed
d2166e3 to
e91216c
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/docs/index.html |
…ut vs code extensions
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/docs/index.html |
|
@agneszitte @Jen-Uno @MartinZikmund (as you reviewed initially) Check this comments for a overview:To be checked from the Team:These Pages/Files are obviously including outdated information, as of v6 Major Version:
Maybe you could have also a look in general, if we could get the markdownlint.json to a .jsonc format (CI flow change therefore this should be checked from Team side) so the lintings and errors showing up there from the // comments in it, would get fixed 👍 |
| <!-- TODO: decide if following line should be changed, since docfx.console is officially depreciated! --> | ||
| - [docfx.console](https://github.com/unoplatform/Uno/pull/1082/commits/c222caf8c23b35e19f6b33cd624cbfa714250bfe) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@booskander could you check on this?
chore: moved the gif file to the assets folder near to the file its used with chore: added the Anchor Links Link to the toc used replace in vs code which should have found all occurrences
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/docs/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/docs/index.html |
|
@jeromelaban would guess here is just that one comment to be checked and seems like bootscander is out of office, do you see anything left to do here? |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days. |
|
@Jen-Uno can you give me some state update on this or what I might need to change to get this finished up and merged/dropped? |
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Current docfx guide is outdated and telling to use docfx.console which has been depreciated
see more Information to this here: dotnet/docfx#9100
Link to the Documentation page
The Uno.Extensions Repository is already having the new commands in its Readme.md
Secondary, the check_toc.ps1 does list almoast every href as not linked to a file, because it does not recognize the xref link declaration
Third page is way smaller changes:
What is the new behavior?
Updated the docfx commands
Problem with that is, I do not understand the UWPSyncGenerator so deeply to decide this. Currently, those comments do stretch the md line distance a bit (vs 2022 preview) althought its hidden.
Added a detailed guide to the usage of check_toc.ps1 along with adding the capability of recognizing and comparing the xref -> uids
The old one does have a different signature...
At the moment it's not part of the CI,so I dont know it should be tested for this again...PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults. -> building docfx is failing because of missing things it seems to medocfx build output.txt
Other information
Above mentioned
Internal Issue (If applicable):