fix(hr): Fix ENC1002 when dealing with event handlers #19418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/code-generation
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19418/index.html |
jeromelaban
reviewed
Feb 1, 2025
| owner.__1_Click_P2_Button_Click_Builder = null; | ||
| owner.__2_Click_P3_Button_Click_Builder?.Invoke( owner._component_2); | ||
| owner.__2_Click_P3_Button_Click_Builder = null; | ||
| owner.__ApplyMethod_0_Click_Initialize(); |
There was a problem hiding this comment.
We should not call those multiple times per component.
jeromelaban
reviewed
Feb 1, 2025
| @@ -39,6 +46,8 @@ public NameScope(string? @namespace, string className) | |||
|
|
|||
| public Dictionary<string, Subclass> Subclasses { get; } = []; | |||
|
|
|||
| public List<Action<IIndentedStringBuilder>> Subclasses2 { get; } = []; | |||
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19418/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19418/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/unoplatform/uno.hotdesign/issues/3289
closes https://github.com/unoplatform/uno.hotdesign/issues/3299
Potentially also fixes:
https://github.com/unoplatform/uno.hotdesign/issues/3290
https://github.com/unoplatform/uno.hotdesign/issues/3281
Bugfix
Fix ENC1002 when dealing with event handlers
What is the current behavior?
Get ENC1002 pretty easily when dealing with element that has event handlers (code behind or x:Bind)
What is the new behavior?
HR
PR Checklist
Screenshots Compare Test Runresults.