chore: Cleanup DependencyPropertyValuePrecedences #15684
Conversation
github-actions
bot
added
the
area/automation
There was a problem hiding this comment.
This should be the first file to review in the PR.
- We were not using
TemplatedParent - We were using
ExplicitStylefor both explicit and implicit styles. - We were using
ImplicitStylefor default styles (as indicated in the deleted remarks section of the doc comment) - We were not using
DefaultStyle
Youssef1313
force-pushed
the
cleanup-dp-precedences
branch
from
8961524 to
af8b5f2
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15684/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15684/index.html |
github-actions
bot
added
the
area/build
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15684/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15684/index.html |
|
Let's let @jeromelaban to confirm, but it seems safe |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15684/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15684/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15684/index.html |
|
Pushing to Uno 6 |
| @@ -345,7 +345,7 @@ void SetDefaultForeground(DependencyProperty foregroundProperty) | |||
| { | |||
| // Hyperlink doesn't appear to inherit foreground from the parent. | |||
| // So, we set this with ImplicitStyle precedence which is a higher precedence than Inheritance. | |||
| this.SetValue(foregroundProperty, DefaultTextForegroundBrush, DependencyPropertyValuePrecedences.ImplicitStyle); | |||
| this.SetValue(foregroundProperty, DefaultTextForegroundBrush, DependencyPropertyValuePrecedences.DefaultStyle); | |||
There was a problem hiding this comment.
The right way to do that is by using this.ForegroundProperty.OverrideMetadata().
There was a problem hiding this comment.
@carldebilly Do you mean to remove the inherits flag? OverrideMetadata will "combine"/"merge" the flags, so it won't work :(
Unless we introduce another overload OverrideMetadata(bool doNotMergeFlags) or so.
We'll probably need to understand how WinUI does this and do the same.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days. |
github-actions
bot
added
the
stale
|
Definitely still needed |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15684/index.html |
github-actions
bot
removed
the
stale
Closes #16356
Removes an unused precedence and renames two others to match their actual semantics.
Note: the removal of the unused precedence makes the current precedences count 8, which means the
DependencyPropertyDetails.Stackarrays will now be of length 8 instead of 16 :)PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):