Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some spelling #15342

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: fix some spelling #15342

wants to merge 2 commits into from

Conversation

SimonCropp
Copy link
Contributor

fix some spelling in comments

@github-actions github-actions bot added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform area/code-generation Categorizes an issue or PR as relevant to code generation area/automation Categorizes an issue or PR as relevant to project automation labels Feb 3, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15342/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15342/index.html

jeromelaban
jeromelaban approved these changes Feb 5, 2024
View reviewed changes
...FluentTheme.v2/Resources/Version2/PriorityDefault/MediaTransportControls_themeresources.xaml
@@ -175,7 +175,7 @@
</VisualStateGroup>
<!-- Media state visual states -->
<!-- Audio Selection Button visibility states -->
<VisualStateGroup x:Name="AudioSelectionAvailablityStates">
<VisualStateGroup x:Name="AudioSelectionAvailabilityStates">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While technically valid, it's an error that comes from WinUI, and we should be keeping the same content as from the original file: https://github.com/microsoft/microsoft-ui-xaml/blob/20dcc18d040aae93f3d464cc96b0023783cdcf73/controls/dev/CommonStyles/MediaTransportControls_themeresources.xaml#L167

src/Uno.UI/UI/Xaml/Controls/Control/Control.mux.cs
@@ -1,6 +1,6 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.
// CCOntrol.cpp, Control_Partial.cpp
// Control.cpp, Control_Partial.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not a typo (Only a casing issue, though)

src/Uno.UI/UI/Xaml/Controls/MediaPlayerElement/MediaTransportControls.mux.h.cs
Comment on lines +134 to +139
public class AudioSelectionAvailabilityStates
{
public const string AudioSelectionAvailable = nameof(AudioSelectionAvailable);
public const string AudioSelectionUnavailable = nameof(AudioSelectionUnavailable);
}
public class CCSelectionAvailablityStates
public class CCSelectionAvailabilityStates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming from the original sources, let's keep then as is.

@jeromelaban
Copy link
Member

Thanks for your contribution!

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days.

@github-actions github-actions bot added the stale This item has been marked as stale and will be closed if there is no activity. label Jan 31, 2025
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15342/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15342/index.html

@github-actions github-actions bot removed the stale This item has been marked as stale and will be closed if there is no activity. label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/code-generation Categorizes an issue or PR as relevant to code generation platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @unodevops @jeromelaban