feat: EnterKeyHint
#13336
Open
feat: EnterKeyHint
#13336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform/wasm 🌐
Youssef1313
reviewed
Aug 21, 2023
ajpinedam
reviewed
Aug 22, 2023
jeromelaban
reviewed
Aug 22, 2023
| #elif __ANDROID__ | ||
| MyTextBox.ImeOptions = ImeAction.Search; | ||
| #elif __WASM__ | ||
| MyTextBox.EnterKeyHint = EnterKeyHint.Search; |
There was a problem hiding this comment.
Should be be creating an attached property that includes this behavior instead? After all, this is Search everywhere and we could hide platform specifics from the user.
There was a problem hiding this comment.
I like Jerome's suggestion. It will highly simplify the usage.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days. |
github-actions
bot
added
the
stale
MartinZikmund
removed
the
stale
MartinZikmund
force-pushed
the
dev/mazi/enterkeyhint
branch
from
512b270 to
b14e1a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #13347
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Missing support
What is the new behavior?
Support for
EnterKeyHintin WebAssembly.Copilot Summary
🤖 Generated by Copilot at d25b09d
This pull request adds support for the
EnterKeyHintproperty to theTextBoxcontrol on WebAssembly, which allows specifying the text and behavior of the enter key on the virtual keyboard. It also adds a new sample page to the SamplesApp project and a new section to the documentation article to demonstrate the usage of the property. Additionally, it refactors some existing code to use the nameof operator for dependency property names.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):