feat: SingleProject - Commerce

[vatsashah45]

No description provided.

[eriklimakc]

Sample updated with latest template.

Known issues so far:

1. WinAppSDK and Android The app uses the file products.json to store the products info. This file lives in the project root directory, but this file is not found by the code when trying to load the products. It only worked for Windows Packaged when I moved the file to Assets. But it didn't work for Android nor Windows Unpackaged.

2. When running the app on Desktop no window is launched. Nothing really happens.

3. On WASM the app is launched, but just a black screen is shown.

I know there are more issues related to loading data. I will post them later after I test it more.

[agneszitte]

@vatsashah45, @eriklimakc
Few comments:

• Remove unnecessary files
• And finally, if you can add a proper ReadMe for the sample please

---

To have a structure similar to what we have for ToDo here, with a src folder with the source inside, a proper README.md with the details of the sample, and a doc folder for additional documentation or assets needed for the README for example.

(cc @LProulx86 as well so we can use the same structure for the others samples)

[eriklimakc]

We're currently facing this issue on this app - unoplatform/uno#16430

[agneszitte]

We're currently facing this issue on this app - unoplatform/uno#16430

@eriklimakc, @vatsashah45 now that unoplatform/uno#16430 is closed, are there any issues left to finish the migration, please?
(cc @nickrandolph)

[eriklimakc]

@eriklimakc, @vatsashah45 now that unoplatform/uno#16430 is closed, are there any issues left to finish the migration, please? (cc @nickrandolph)

Yes, I don't see the build error anymore, so that's fixed. But I see a regression, the Uno.Extensions.Storage.FileStorage issue (https://github.com/unoplatform/uno-private/issues/408) is back only on wasm, and that prevents products from loading:

cc @agneszitte @jeromelaban @nickrandolph

[rajamatt]

With latest packages the warnings for everything related to appsettings still appear on Wasm and other platforms:

However, the products.json file does not appear in the warnings. In fact, all the products are loaded and all feeds with products are working as expected.

cc: @agneszitte

[rajamatt]

Favorites

All items are favorited by default but they don't appear in the Favorites feed, we have to unfavorite them and favorite them again for them to appear in the Favorites feed.

Related issue opened: #737

[rajamatt]

Cart

• Quantity of items in the cart can't be changed, the "More" and "Less" commands are never bound to in the Xaml
• Items can't be removed from the cart because the "Remove" command is never bound to in the Xaml

Uno.Samples/reference/Commerce/src/Commerce/Presentation/CartViewModel.cs

Lines 7 to 14 in bc73777

	public async ValueTask Remove(CartItem item, CancellationToken ct)
	=> await CartService.Remove(item.Product, ct);
	public async ValueTask More(CartItem item, CancellationToken ct)
	=> await CartService.Update(item.Product, item.Quantity + 1, ct);
	public async ValueTask Less(CartItem item, CancellationToken ct)
	=> await CartService.Update(item.Product, item.Quantity - 1, ct);

• Number of items in cart is hardcoded

Uno.Samples/reference/Commerce/src/Commerce/Views/CartPage.xaml

Line 34 in bc73777

Text="3 Items"

---

Related issue opened: #738

[rajamatt]

ProductsPage (search page)

• The "Products found" count is hardcoded
  

  Uno.Samples/reference/Commerce/src/Commerce/Views/ProductsPage.xaml

  Line 66 in bc73777

  Text="5254 products found"

  
  Related issue opened: [Commerce] [ProductsPage] The "Products found" count is hardcoded #739

• Searching for products only works if a filter is selected first

• Clicking on an item in the Search doesn't do anything (should it?)
  Related issue opened: [Commerce] [ProductsPage] Searching for a product only works if a filter is selected beforehand #740

[rajamatt]

Miscellaneous

• About 1/5 of the time, navigating to the profile page causes a COMException (I think its because the profile pictures are random and one of them might be problematic but I'm not sure)
  Related issue opened: [Commerce] [ProfilePage] Navigating to the profile page causes a COMException sometimes #741
  

• Back buttons aren't visible but are functional (not sure if it's theming related or not)
  ** Related issue opened: [Commerce] Back buttons aren't visible but are functional  #742**
  

• The left hand navbar's items could be spaced a bit better (they are very close together and the focus background stacks on adjacent items)
  Related issue opened: [Commerce] The left hand navbar's items could be spaced a bit better #743
  

[kazo0]

@rajamatt can you create separate issues for those things you've noticed. And I can also reproduce them on current master so it doesnt seem to be related to this pr

[agneszitte]

Another related issue opened: [Commerce] Images are too large
#735

[rajamatt]

@rajamatt can you create separate issues for those things you've noticed. And I can also reproduce them on current master so it doesnt seem to be related to this pr

Done