Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Split by case should take space into account #98

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

noootwo
Copy link

@noootwo noootwo commented Nov 21, 2024

fix #95
fix #92

I think for the titleCase, the , should not be took into account.

@noootwo
Copy link
Author

noootwo commented Nov 21, 2024

It seem all punctuation needs to be preserved, do we need to take all punctuation into account and filter them at titleCase?

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (32ee7f5) to head (c0a6e9a).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #98   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          340       364   +24     
  Branches        39        45    +6     
=========================================
+ Hits           340       364   +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

src/index.ts Outdated Show resolved Hide resolved
@pi0
Copy link
Member

pi0 commented Nov 21, 2024

It seem all punctuation needs to be preserved

I think that would make sense. Little bit tricky as makes change potential behavior breaking change.

I suggest to go one with this PR as-is and another followup later for v2

@noootwo
Copy link
Author

noootwo commented Nov 22, 2024

It seem all punctuation needs to be preserved

I think that would make sense. Little bit tricky as makes change potential behavior breaking change.

I suggest to go one with this PR as-is and another followup later for v2

Ok, this PR is ready

When will the follow-up work be planned? I 'd be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent casing Split by case should take , and space into account
2 participants