-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Split by case should take space into account #98
base: main
Are you sure you want to change the base?
Conversation
It seem all punctuation needs to be preserved, do we need to take all punctuation into account and filter them at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 340 364 +24
Branches 39 45 +6
=========================================
+ Hits 340 364 +24 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I think that would make sense. Little bit tricky as makes change potential behavior breaking change. I suggest to go one with this PR as-is and another followup later for v2 |
Ok, this PR is ready When will the follow-up work be planned? I 'd be happy to help. |
fix #95
fix #92
I think for the
titleCase
, the,
should not be took into account.