Skip to content

Conversation

@ChrisPenner
Copy link
Member

@ChrisPenner ChrisPenner commented Oct 23, 2025

Overview

Sorry, I know this is annoying and spans a big chunk of the codebase.

Switches a bunch of stuff from String -> Text;
We're still using String in a lot of low-level stuff, which is going to be inefficient both in memory and cpu when doing a bunch of text munging.

Specifically I wanted to switch AnnotatedText to actually use Text so I can use Text primitives when working with it (without needing to switch back and forth a bunch).

I'll be building some of the diffing improvements on top of this.

Implementation notes

  • Switch AnnotatedText to use Text, then propagate that out to natural stopping points.
  • I didn't push it all the way out, but went as far as I reasonably coul.

Test coverage

Existing tests

@ChrisPenner ChrisPenner marked this pull request as ready for review October 23, 2025 00:25
@ChrisPenner ChrisPenner requested a review from aryairani October 23, 2025 17:03
@aryairani aryairani merged commit 8a687ea into trunk Oct 24, 2025
32 checks passed
@aryairani aryairani deleted the cp/annotated-string-text branch October 24, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants