Re-enable isort and run on codebase #1295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan McDougall <[email protected]>
Signed-off-by: Nathan McDougall <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
===========================================
- Coverage 94.28% 77.13% -17.15%
===========================================
Files 91 91
Lines 7013 7011 -2
===========================================
- Hits 6612 5408 -1204
- Misses 401 1603 +1202 ☔ View full report in Codecov by Sentry. |
nathanjmcdougall
added a commit
to nathanjmcdougall/pandera
that referenced
this pull request
Aug 8, 2023
That is for files with pre-3.9 annotations with view to migrate Incidentally run isort (see unionai-oss#1295) Signed-off-by: Nathan McDougall <[email protected]>
|
hey @nathanjmcdougall would you mind taking a look at some of the merge conflicts? Not sure what was added/reordered by isort |
Signed-off-by: Nathan McDougall <[email protected]>
Signed-off-by: Nathan McDougall <[email protected]>
Signed-off-by: Nathan McDougall <[email protected]>
Signed-off-by: Nathan McDougall <[email protected]>
|
@cosmicBboy I've taken a look - unfortunately seems there's an issue with attribute access in one of the doctests - as far as I can tell this is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, isort isn't running because of the
--diffoption which effectively turns it into a print-only tool. The pre-commit doesn't actually print anything though, and it doesn't raise any exit code so the pre-commit, CI etc. will pass even when the tool thinks things are unsorted.Similar to #1292, I suggest moving the configuration out of the pre-commit config file (and also setup.cfg) and into pyproject.toml.
I've run isort across the entire codebase, so a lot of files have changed (only cosmetically, of course).