Fix internalSkeleton #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going over UTS #39 I noticed that the
internalSkeleton
function is defined as:But in the current implementation, we leave out step 2 which probably does not change the behaviour in most cases. Still, it is likely a good idea to fix this.
This pull request adds this step.
Notes:
load_properties
inunicode.py
to effectively remove a copy of the function.