-
Notifications
You must be signed in to change notification settings - Fork 214
Baked data: use VarULE to store data when specified #6133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
522e1ab
impl ULE for ()
sffc 309d12d
Add MaybeAsVarULE and impl on all data structs
sffc 8d45d49
Start integrating into BakedExporter
sffc 5c34469
Implement on HelloWorld
sffc a814e3b
datagen
sffc 781fe51
Almost done
sffc 1eee363
Add the missing impl
sffc 9b18826
fmt
sffc 5bd8b18
Reduce diff; DRY
sffc 255122a
clean datagen (not word break?)
sffc 1eb0897
datagen for word break (it appears the same, it just doesn't format)
sffc c1e86b1
features
sffc 6eea0dd
macro test
sffc fc564ea
clippy
sffc e73da50
Merge branch 'main' into maybe-as-varule
sffc 81035bb
MaybeExportAsVarULE
sffc 4cc5166
NeverVarULE
sffc 2e09206
remove impl ULE for ()
sffc 035abb3
Add MaybeExportAsVarULE::from_varule
sffc 8c12687
Rename macro to data_struct
sffc d6dcd09
Docs for the struct
sffc 8ffb284
Use macro to implement the trait for HelloWorld
sffc 889a44f
fmt
sffc c3e539f
New three traits; move to `icu_provider::ule` module
sffc 8eb18c5
Switch from box to reference for now (https://github.com/unicode-org/…
sffc dd381a4
Fix docs links
sffc a343f01
Revert "remove impl ULE for ()"
sffc 8511175
Switch from NeverVarULE back to [()]
sffc 9f42022
Add `TODO(#6164)`
sffc 32b18c6
Try migrating to a bake that happens in DataPayload
sffc cd71e4a
Switch to baking VarZeroSlice, and datagen
sffc de923c3
tokenize_to_varzeroslice
sffc ef365c5
EncodedStruct
sffc b51cc77
Add issue number to TODO
sffc 6eccf2e
data_struct_new!
sffc bf91bd4
Fix the types in the data_struct_new macro definition
sffc d5c1922
Do some magic tricks to use closures in the macro
sffc 77062f3
Merge remote-tracking branch 'upstream/main' into maybe-as-varule
sffc 510b2cf
tokenize_encoded_seq
sffc e35d9e2
Merge remote-tracking branch 'upstream/main' into maybe-as-varule
sffc bdab081
Catch up on bitrot; clippy
sffc af6e5a5
doc
sffc b3d00a2
features
sffc a8e2ce3
FromVarULE -> ZeroFrom
sffc ccf35ba
Safety doc tweaks
sffc bb86f4a
Update provider/core/src/varule_traits.rs
sffc 0bcc8af
cfg(feature = "datagen")
sffc 901cd21
TODO(#5230)
sffc e55933c
Remove the word "storage" from optimization remark
sffc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.