clean up FixedDecimal allowlist

unicode-org · Jan 2, 2025 · acdc577 · acdc577
1 parent eec6684
commit acdc577
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 58 deletions.
diff --git a/ffi/capi/src/fixed_decimal.rs b/ffi/capi/src/fixed_decimal.rs
@@ -16,6 +16,7 @@ pub mod ffi {
 
     #[diplomat::opaque]
     #[diplomat::rust_link(fixed_decimal::FixedDecimal, Struct)]
+    #[diplomat::rust_link(fixed_decimal::SignedFixedDecimal, Typedef, hidden)]
     pub struct SignedFixedDecimal(pub fixed_decimal::SignedFixedDecimal);
 
     /// The sign of a FixedDecimal, as shown in formatting.

diff --git a/ffi/capi/tests/missing_apis.txt b/ffi/capi/tests/missing_apis.txt
@@ -14,64 +14,6 @@
 # Please check in with @Manishearth, @robertbastian, or @sffc if you have questions
 
 
-fixed_decimal::Signed#Struct
-fixed_decimal::Signed::apply_sign_display#FnInStruct
-fixed_decimal::Signed::ceil#FnInStruct
-fixed_decimal::Signed::ceiled#FnInStruct
-fixed_decimal::Signed::expand#FnInStruct
-fixed_decimal::Signed::expanded#FnInStruct
-fixed_decimal::Signed::floor#FnInStruct
-fixed_decimal::Signed::floored#FnInStruct
-fixed_decimal::Signed::new#FnInStruct
-fixed_decimal::Signed::round#FnInStruct
-fixed_decimal::Signed::round_with_mode#FnInStruct
-fixed_decimal::Signed::round_with_mode_and_increment#FnInStruct
-fixed_decimal::Signed::rounded#FnInStruct
-fixed_decimal::Signed::rounded_with_mode#FnInStruct
-fixed_decimal::Signed::rounded_with_mode_and_increment#FnInStruct
-fixed_decimal::Signed::set_sign#FnInStruct
-fixed_decimal::Signed::sign#FnInStruct
-fixed_decimal::Signed::to_string#FnInStruct
-fixed_decimal::Signed::trunc#FnInStruct
-fixed_decimal::Signed::trunced#FnInStruct
-fixed_decimal::Signed::try_from_f64#FnInStruct
-fixed_decimal::Signed::try_from_str#FnInStruct
-fixed_decimal::Signed::try_from_utf8#FnInStruct
-fixed_decimal::Signed::with_sign#FnInStruct
-fixed_decimal::Signed::with_sign_display#FnInStruct
-fixed_decimal::SignedFixedDecimal#Typedef
-fixed_decimal::UnsignedFixedDecimal#Struct
-fixed_decimal::UnsignedFixedDecimal::concatenate_end#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::concatenated_end#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::expand#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::expanded#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::from_str#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::multiplied_pow10#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::multiply_pow10#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::pad_end#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::pad_start#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::padded_end#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::padded_start#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::round#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::round_with_mode#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::round_with_mode_and_increment#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::rounded#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::rounded_with_mode#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::rounded_with_mode_and_increment#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::set_max_position#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::to_string#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::trim_end#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::trim_start#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::trimmed_end#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::trimmed_start#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::trunc#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::trunced#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::try_from_f64#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::try_from_str#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::try_from_utf8#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::with_max_position#FnInStruct
-fixed_decimal::UnsignedFixedDecimal::write_to#FnInStruct
-fixed_decimal::UnsignedRoundingMode#Enum
 icu::calendar::types::YearAmbiguity#Enum
 icu::calendar::types::YearInfo::year_ambiguity#FnInStruct
 icu::collator::CollatorPreferences::extend#FnInStruct

diff --git a/tools/make/diplomat-coverage/src/allowlist.rs b/tools/make/diplomat-coverage/src/allowlist.rs
@@ -254,6 +254,13 @@ lazy_static::lazy_static! {
         "icu_provider_adapters::fork::ForkByErrorProvider",
         "icu_provider_adapters::fork::predicates::ForkByErrorPredicate",
 
+        // Not planned for 2.0
+        // We will revisit these APIs when Duration Formatter needs them. We may need to rename things
+        "fixed_decimal::Signed",
+        "fixed_decimal::UnsignedFixedDecimal",
+        "fixed_decimal::UnsignedRoundingMode",
+
+
         // Stuff that is experimental
         //
         // We should occasionally review these