Skip to content

Conversation

@eggrobin
Copy link
Member

Suggested by @jmr after seeing the error messages generated by UTFStringCodePoints<..., char> (which was how this API worked in an earlier draft).

TODO: Fill out the checklist below.

Checklist

  • Required: Issue filed: ICU-NNNNN
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@eggrobin
Copy link
Member Author

@markusicu, should this target main on a new ticket, or 78 maintenance on a reopened ICU-23004?

@eggrobin eggrobin requested a review from markusicu October 22, 2025 14:12
@markusicu
Copy link
Member

markusicu commented Oct 23, 2025

@markusicu, should this target main on a new ticket, or 78 maintenance on a reopened ICU-23004?

@eggrobin is this PR fixing problems, or just "improv[ing] error messages"?
If it's an important bug fix, then it should go onto the maintenance branch, with the existing ticket.
If it's merely an improvement, then it should go onto main for ICU 79.

@mihnita @richgillam FYI

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as an improvement for ICU 79 -- please create an ICU 79 ticket for such improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants