ICU-23232 Add malloc check in putil #3718
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYFTang
requested changes
Oct 29, 2025
icu4c/source/common/putil.cpp
Outdated
| rewind(tzInfo->defaultTZFilePtr); | ||
| tzInfo->defaultTZBuffer = static_cast<char*>(uprv_malloc(sizeof(char) * tzInfo->defaultTZFileSize)); | ||
| if (tzInfo->defaultTZBuffer == nullptr) { | ||
| result = false; |
Contributor
There was a problem hiding this comment.
why not just
if (tzInfo->defaultTZBuffer == nullptr) {
fclose(file);
return false;
}
?
wooffie
force-pushed
the
fix-ICU-23232
branch
from
45ed9e1 to
8621297
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
wooffie
force-pushed
the
fix-ICU-23232
branch
from
8621297 to
bdc8d42
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe can refactor with STATUS returning.
Checklist