Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22966 Fix -Wshadow warnings in unicode/uset.h #3331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

th1722
Copy link

@th1722 th1722 commented Jan 11, 2025

Fix -Wshadow warnings displayed when compiling ICU4C 76.1 or later.

Checklist

  • Required: Issue filed: ICU-22966
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Fix -Wshadow warnings displayed
when compiling ICU4C 76.1 or later.

Co-authored-by: Xisco Fauli <[email protected]>
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Member

@roubert roubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ICU4C doesn't have any kind of style guide for how to name members vs. their initializers and common usage varies around the code base, so even though this kind of Hungarian notation used here isn't commonly used within ICU4C I guess its usage here is as good as any other way to distinguish them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants