-
-
Notifications
You must be signed in to change notification settings - Fork 12
Refactor ICU4X code to allow configured code by version #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Problems encountered in using this in all versions (1.3, 1.4, 1.5, and 2.0_beta)* $ gh pr checkout 377
For more information about this error, try
For more information about this error, try |
After rustup 1.80, this works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pub mod relativedatetime_fmt; | ||
|
||
#[cfg(any(ver = "1.3", ver = "1.4", ver = "1.5"))] | ||
#[path = "datetime_1.rs"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I like the way you did this. I didn't know that you can configure which file Cargo should look at to find a particular module, but that's really convenient for this use case.
Unblocks #372