Skip to content

fix: bg in dark mode hover state for hide counts button#1304

Closed
yardensachs wants to merge 1 commit intounfoldadmin:mainfrom
yardensachs:yardensachs/fix-issue-darkmode-filter-button
Closed

fix: bg in dark mode hover state for hide counts button#1304
yardensachs wants to merge 1 commit intounfoldadmin:mainfrom
yardensachs:yardensachs/fix-issue-darkmode-filter-button

Conversation

@yardensachs
Copy link
Copy Markdown

Fixes #1303

@lukasvinclav
Copy link
Copy Markdown
Contributor

Thanks for the PR. I just checked the functionality on the demo site and it works correctly for me:

http://localhost:8000/en/admin/formula/driverwithfilters/

Would you mind testing it? Please refresh the local cache before test. Thanks

@yardensachs
Copy link
Copy Markdown
Author

@lukasvinclav I was trying this one:
https://demo.unfoldadmin.com/en/admin/formula/driverwithfilters/?_facets=True

You need to click on show counts first, and its only an issue with Hide Counts button

@lukasvinclav
Copy link
Copy Markdown
Contributor

Thanks for the PR. I checked the code and I noticed the trick was removing wrong background color:

#1314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter's button in dark mode uses an inappropriate light hover color

2 participants