Skip to content

Filter's button in dark mode uses an inappropriate light hover color #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yardensachs opened this issue May 17, 2025 · 1 comment
Closed

Filter's button in dark mode uses an inappropriate light hover color #1303

yardensachs opened this issue May 17, 2025 · 1 comment

Comments

@yardensachs
Copy link

yardensachs commented May 17, 2025 •
edited
Loading

Description

In dark mode, certain buttons (specifically the "Hide Counts" button in the filter panel) display with a white background color on hover. This creates a visual inconsistency with the dark theme and causes poor contrast with surrounding elements.

Screen.Recording.2025-05-17.at.2.50.59.PM.mov

Current Behavior

When hovering over the "Hide Counts" button in dark mode - the button background changes to white

Expected Behavior

When hovering over buttons in dark mode - the button background should use a dark-appropriate hover color

Issue

django-unfold/src/unfold/templates/unfold/helpers/change_list_filter_actions.html

Line 15 in 5c1125d

<a href="{{ cl.remove_facet_link }}" class="hidelink border grow font-medium px-3 py-2 rounded-default text-center transition-all w-full hover:bg-base-50 lg:w-auto dark:border-base-700 dark:hover:text-base-200">

The issue is that hover:bg-base-50 is the only bg class on hover. Its missing dark:hover:bg-base-900
@yardensachs yardensachs mentioned this issue May 17, 2025
Closed
@lukasvinclav
Copy link
Contributor

Thanks for report. Fixed in #1314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bg in dark mode hover state for hide counts button yardensachs/django-unfold
2 participants
@yardensachs @lukasvinclav