Add Import/Export functionality for settings and configurations#424
Add Import/Export functionality for settings and configurations#424unchihugo merged 3 commits intounchihugo:masterfrom
Conversation
This intends to add the functionality of import and export settings file as described and requested on issue unchihugo#336
master from head repo to my repo
github-actions
bot
added
the
SettingsWindow
unchihugo
left a comment
unchihugo
left a comment
There was a problem hiding this comment.
Hi @FaroJoaoFaro, thank you for working on this! Looks great so far.
I'm not able to review this on my computer atm, so I'm just commenting based on what I can see in code. I have some thoughts before we merge:
- The new import and export methods look very similar to the existing restore and save methods. Is there a way to perhaps consolidate them to reuse the code instead?
- I see you've added null conditions to the messagebox strings, which is great but actually isn't necessary in our case: the resource dictionary key will never be null because we have a fallback mechanic that guarantees English backup strings. (You might've picked this up from other areas of the code but honestly they should be removed as well.)
Could you please address those things? Other than that though, it looks great!
…ngs logic instead of using the ExportSettings and ImportSettings we can reuse the functions RestoreSettings and SaveSettings also removed null conditions on the messagebox strings
|
1- You were completely right! Totally usable; Thanks! Hope this is good! |
unchihugo
left a comment
unchihugo
left a comment
There was a problem hiding this comment.
Hi, looks perfect now! I'm just going to edit the location of the options to be in Settings > System (I think it's more appropriate there), hope you don't mind!
2 participants
This intends to add the functionality of import and export settings file as described and requested on issue #336