Skip to content

feat(ri): hide the navigation until the pages it links to exist#719

Merged
ashleythedeveloper merged 2 commits into
nextfrom
feat/hide-navigation
Jun 12, 2026
Merged

feat(ri): hide the navigation until the pages it links to exist#719
ashleythedeveloper merged 2 commits into
nextfrom
feat/hide-navigation

Conversation

@ashleythedeveloper

@ashleythedeveloper ashleythedeveloper commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

This PR hides the reference implementation's navigation behind a SHOW_NAVIGATION flag, so users no longer see a sidebar and header whose destination pages are stubs.
The public header, the protected sidebar (desktop and mobile), and all their wiring remain in the codebase; reinstating the navigation later is a one-flag flip per layout.

Closes #715

Test plan

  • Public pages render children and footer without the header, with the AppBar top offset removed
  • Protected pages render without the sidebars, keeping the auth redirect, loading state, and DID context
  • The absence tests fail if the navigation is rendered again (verified by flipping the flag)
  • The verify page error-state helper no longer requires an unrelated button to exist (it previously matched the header menu button)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a SHOW_NAVIGATION flag set to false in both the protected and public layouts to temporarily hide navigation components (sidebars and header) until their target pages exist. The layout test files have been updated or added to verify this behavior and ensure children render correctly without the navigation elements. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ashleythedeveloper ashleythedeveloper merged commit 04f37dd into next Jun 12, 2026
14 checks passed
@ashleythedeveloper ashleythedeveloper deleted the feat/hide-navigation branch June 12, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide the reference implementation navigation until the pages it links to exist

1 participant