This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
[DISCUSS] Remove packery - custom js #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think we've been using it in correct terms of the license, and I also think it has some performance issues in the browser as it condenses the grid.
This class is to replace packery by doing the tiling at html render time, rather than in JS on the browser. We construct a Tiler with a number of rows and columns. When we add a tile we say what size it is (default is 1x1) and when we layout the tiles the tiler will fit things in and fill up spaces created by adding larger tiles using any future smaller tiles if possible.
The HTML now includes data attributes telling the JS tiler the grid location of each tile, it's size, and the gap between tiles (this data lives on the container, not each tile). The tiler then iterates over each tile and absolutely positions each tile accordingly.
h-lame
force-pushed
the
remove-packery-custom-js
branch
from
1f311a6 to
6a31d24
Compare
|
TODO:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using the packery library to layout the blog posts in a condensed gird, something that at the time of development was impossible to do with pure css. However, I'm almost certain that we've not paid the license fee to be allowed to do so on the site, so we should remove it. This PR replaces it with a custom JS alternative. We don't need to do as much work as packery as our ruby Tiler makes sure each blog tile is in the right place and we have the grid locations as data attributes in the HTML. This JS tiler just needs to go through and absolutely position each tile rather than doing the more complex work that packery does. We may need to do some performance comparisons though to make sure it's not slow.
This is an alternative to #300 and #299