Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consultee magic link auth using sgid #2116

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Consultee magic link auth using sgid #2116

merged 1 commit into from
Jan 20, 2025

Conversation

benbaumann95
Copy link
Member

@benbaumann95 benbaumann95 commented Jan 15, 2025

Description of change

Use global signed ID for magic link auth

  • Handle valid and invalid sgid in magic link
  • Handle expired resource so that end users can request a new magic link if previous link has expired

Story Link

https://trello.com/c/8VoNhP0c/320-authentication-for-consultees-with-magic-link

@benbaumann95 benbaumann95 changed the title Consultee magic link auth using dgid Consultee magic link auth using sgid Jan 15, 2025
@benbaumann95 benbaumann95 force-pushed the consultee-auth branch 2 times, most recently from 8bf75da to f05dfd9 Compare January 20, 2025 09:42
@benbaumann95 benbaumann95 marked this pull request as ready for review January 20, 2025 09:44
@benbaumann95 benbaumann95 force-pushed the consultee-auth branch 17 times, most recently from 035d89b to 35f9c21 Compare January 20, 2025 15:14
Copy link
Contributor

@benjamineskola benjamineskola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor things, feel free to ignore if they don't make sense to you.

- Handle valid and invalid sgid in magic link
- Handle expired resource so that magic link user can request a new link if previous link has expired
- Add magic link mailer for consultee
@benbaumann95 benbaumann95 merged commit da878cb into main Jan 20, 2025
25 checks passed
@benbaumann95 benbaumann95 deleted the consultee-auth branch January 20, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants