fix for #1143 #2695

wszak · 2024-11-15T16:52:30Z

replace strings with unicode for python3
fixes #1143

xrmx

Patch looks fine but could you please add the PYTHREE guards instead of removing py2 code?

+#ifdef PYTHREE
+                                       k = PyUnicode_FromStringAndSize(*e, (int)(p-*e));
+#else
                                        k = PyString_FromStringAndSize(*e, (int)(p-*e));
+#endif

Fixes the following stacktrace with the options enabled: Traceback (most recent call last): File "/srv/knip/development/KnipKnap/lib/python3.4/os.py", line 637, in __setitem__ key = self.encodekey(key) File "/srv/knip/development/KnipKnap/lib/python3.4/os.py", line 706, in encode raise TypeError("str expected, not %s" % type(value).__name__) TypeError: str expected, not bytes

xrmx reviewed Apr 9, 2025

View reviewed changes

xrmx force-pushed the fix1143 branch from e6c77c9 to 4e3e534 Compare April 11, 2025 18:43

xrmx merged commit f57eed9 into unbit:master Apr 11, 2025
23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix for #1143 #2695

fix for #1143 #2695

wszak commented Nov 15, 2024

xrmx left a comment •

edited

Loading

fix for #1143 #2695

fix for #1143 #2695

Conversation

wszak commented Nov 15, 2024

xrmx left a comment • edited Loading

Choose a reason for hiding this comment

xrmx left a comment •

edited

Loading