chore: Upgrade arti_client to 0.24 #18
Conversation
|
Thank you for your effort!!! Can you tell me what you are using this for? |
|
Thanks for your effort. However it looks like it no longer compiles with the version update. This likely to updates or movements. Could you resolve these problems? |
We are using this for our implementation of Monero <> Bitcoin atomic swaps. I'm super hyped to use this crate, both for privacy and to allow users to listen on an onion address without having to expose any ports. Previously, we bundled a pre-compiled I'm still trying to adapt the code to use the new |
|
The approach of using this instead of a SOCKS5 proxy is indeed a good idea. |
|
I don't know your use case that well but I want to note, that the security could be easily compromised by an incorrect use of identify, so bear that in mind. |
Cargo.toml
Outdated
| edition = "2021" | ||
| description = "Tor transport for libp2p" | ||
| repository = "https://github.com/hannes-furmans/libp2p-community-tor" |
There was a problem hiding this comment.
This is not the url of this repository.
src/lib.rs
Outdated
| //! ## Example (async-std + native-tls) | ||
| //! ```no_run | ||
| //! # use async_std_crate as async_std; | ||
| //! # use libp2p_core::Transport; | ||
| //! # async fn test_func() -> Result<(), Box<dyn std::error::Error>> { | ||
| //! let address = "/dns/www.torproject.org/tcp/1000".parse()?; | ||
| //! let mut transport = libp2p_community_tor::AsyncStdNativeTlsTorTransport::bootstrapped().await?; | ||
| //! // we have achieved tor connection | ||
| //! let _conn = transport.dial(address)?.await?; | ||
| //! # Ok(()) | ||
| //! # } | ||
| //! # async_std::task::block_on(async { test_func().await.unwrap() }); | ||
| //! ``` |
There was a problem hiding this comment.
Why do you remove the example?
|
Sorry for the confusion. This is not ready for review yet. I did a dirty proof-of-concept to get this compiling, and used Claude 3.5 for some of the changes. I definitely didn't intend to remove your copyright / parts of your documentation. I'll ping you once this is ready :) |
|
oh okay, no worries :) |
I know, my fault. |
Co-authored-by: Hannes <[email protected]>
…dundant features for tokio
|
@umgefahren This is ready for review. |
| @@ -33,80 +33,54 @@ | |||
| //! Use with caution and at your own risk. **Don't** just blindly advertise Tor without fully understanding what you | |||
| //! are dealing with. | |||
| //! | |||
| //! Main entrypoint of the crate: [`TorTransport`] | |||
There was a problem hiding this comment.
I still think that's helpful :)
|
Thank you for your work! May I ask why you didn't update to libp2p to 0.54.1? |
We are still on 0.53. Once we upgrade, I'll open a PR to upgrade this crate too. |
- Upgrade `sqlx` to `0.8` - Use `[email protected]` in combination with [`libp2p-community-tor`](https://crates.io/crates/libp2p-community-tor/0.4.1). umgefahren/libp2p-tor#18 was required for this. - Display spinner in GUI while Tor circuits are being established - Remove unused dependencies (`once_cell`, `tauri-plugin-devtools`, `digest`, `hyper`, `itertools`, `erased_serde`) - Bundle roboto font from npm registry
This PR:
libp2pcrate version to 0.53arti_clientcrate to 0.24TorTransport::from_clientbuilder method to construct a transport from an already existing Arti clientCloses #17